* [PATCH v2] can: ti_hecc: Replace platform dependency with ARM dependency
@ 2013-12-20 20:14 Ezequiel Garcia
2013-12-20 21:17 ` Sergei Shtylyov
0 siblings, 1 reply; 6+ messages in thread
From: Ezequiel Garcia @ 2013-12-20 20:14 UTC (permalink / raw)
To: netdev, linux-can; +Cc: Marc Kleine-Budde, Ezequiel Garcia
OMAP's ti_hecc driver is used to support the CAN controller on many omap2plus
SoCs (OMAP2430, OMAP3, OMAP4, OMAP5 and AM335x), so it's wrong to make this
depend on OMAP3 only. Take an extra step, to get wider build coverage, and make
the driver depend on ARM.
Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
---
drivers/net/can/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig
index 3c06947..9e7d95d 100644
--- a/drivers/net/can/Kconfig
+++ b/drivers/net/can/Kconfig
@@ -71,7 +71,7 @@ config CAN_AT91
and AT91SAM9X5 processors.
config CAN_TI_HECC
- depends on ARCH_OMAP3
+ depends on ARM
tristate "TI High End CAN Controller"
---help---
Driver for TI HECC (High End CAN Controller) module found on many
--
1.8.1.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] can: ti_hecc: Replace platform dependency with ARM dependency
2013-12-20 20:14 [PATCH v2] can: ti_hecc: Replace platform dependency with ARM dependency Ezequiel Garcia
@ 2013-12-20 21:17 ` Sergei Shtylyov
2013-12-20 21:33 ` Ezequiel Garcia
0 siblings, 1 reply; 6+ messages in thread
From: Sergei Shtylyov @ 2013-12-20 21:17 UTC (permalink / raw)
To: Ezequiel Garcia, netdev, linux-can; +Cc: Marc Kleine-Budde
Hello.
On 12/20/2013 11:14 PM, Ezequiel Garcia wrote:
> OMAP's ti_hecc driver is used to support the CAN controller on many omap2plus
> SoCs (OMAP2430, OMAP3, OMAP4, OMAP5 and AM335x), so it's wrong to make this
> depend on OMAP3 only. Take an extra step, to get wider build coverage, and make
> the driver depend on ARM.
To have a real wide coverage, it's probably worth adding '|| COMIPLE_TEXT'
to 'depends on ARCH_OMAP2PLUS'?
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
WBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] can: ti_hecc: Replace platform dependency with ARM dependency
2013-12-20 21:17 ` Sergei Shtylyov
@ 2013-12-20 21:33 ` Ezequiel Garcia
2013-12-21 21:06 ` Marc Kleine-Budde
0 siblings, 1 reply; 6+ messages in thread
From: Ezequiel Garcia @ 2013-12-20 21:33 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: netdev, linux-can, Marc Kleine-Budde
On Sat, Dec 21, 2013 at 12:17:27AM +0300, Sergei Shtylyov wrote:
> On 12/20/2013 11:14 PM, Ezequiel Garcia wrote:
>
> > OMAP's ti_hecc driver is used to support the CAN controller on many omap2plus
> > SoCs (OMAP2430, OMAP3, OMAP4, OMAP5 and AM335x), so it's wrong to make this
> > depend on OMAP3 only. Take an extra step, to get wider build coverage, and make
> > the driver depend on ARM.
>
> To have a real wide coverage, it's probably worth adding '|| COMIPLE_TEXT'
> to 'depends on ARCH_OMAP2PLUS'?
>
Yup, and that was my exact proposal on my reply to v1 (which I forgot to detail
in v2). I'd say it's Marc's call.
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] can: ti_hecc: Replace platform dependency with ARM dependency
2013-12-20 21:33 ` Ezequiel Garcia
@ 2013-12-21 21:06 ` Marc Kleine-Budde
2013-12-21 22:16 ` Sergei Shtylyov
0 siblings, 1 reply; 6+ messages in thread
From: Marc Kleine-Budde @ 2013-12-21 21:06 UTC (permalink / raw)
To: Ezequiel Garcia; +Cc: Sergei Shtylyov, netdev, linux-can
[-- Attachment #1: Type: text/plain, Size: 1082 bytes --]
On 12/20/2013 10:33 PM, Ezequiel Garcia wrote:
> On Sat, Dec 21, 2013 at 12:17:27AM +0300, Sergei Shtylyov wrote:
>> On 12/20/2013 11:14 PM, Ezequiel Garcia wrote:
>>
>>> OMAP's ti_hecc driver is used to support the CAN controller on many omap2plus
>>> SoCs (OMAP2430, OMAP3, OMAP4, OMAP5 and AM335x), so it's wrong to make this
>>> depend on OMAP3 only. Take an extra step, to get wider build coverage, and make
>>> the driver depend on ARM.
>>
>> To have a real wide coverage, it's probably worth adding '|| COMIPLE_TEXT'
>> to 'depends on ARCH_OMAP2PLUS'?
> Yup, and that was my exact proposal on my reply to v1 (which I forgot to detail
> in v2). I'd say it's Marc's call.
Convinced, I've added the v1 of this patch to can-next together with a
|| COMIPLE_TEXT.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] can: ti_hecc: Replace platform dependency with ARM dependency
2013-12-21 21:06 ` Marc Kleine-Budde
@ 2013-12-21 22:16 ` Sergei Shtylyov
2013-12-21 21:32 ` Marc Kleine-Budde
0 siblings, 1 reply; 6+ messages in thread
From: Sergei Shtylyov @ 2013-12-21 22:16 UTC (permalink / raw)
To: Marc Kleine-Budde, Ezequiel Garcia; +Cc: netdev, linux-can
Hello.
On 12/22/2013 12:06 AM, Marc Kleine-Budde wrote:
>>>> OMAP's ti_hecc driver is used to support the CAN controller on many omap2plus
>>>> SoCs (OMAP2430, OMAP3, OMAP4, OMAP5 and AM335x), so it's wrong to make this
>>>> depend on OMAP3 only. Take an extra step, to get wider build coverage, and make
>>>> the driver depend on ARM.
>>> To have a real wide coverage, it's probably worth adding '|| COMIPLE_TEXT'
>>> to 'depends on ARCH_OMAP2PLUS'?
>> Yup, and that was my exact proposal on my reply to v1 (which I forgot to detail
>> in v2). I'd say it's Marc's call.
> Convinced, I've added the v1 of this patch to can-next together with a
> || COMIPLE_TEXT.
Sorry, I meant COMPILE_TEST, of course. :-<
> regards,
> Marc
WBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] can: ti_hecc: Replace platform dependency with ARM dependency
2013-12-21 22:16 ` Sergei Shtylyov
@ 2013-12-21 21:32 ` Marc Kleine-Budde
0 siblings, 0 replies; 6+ messages in thread
From: Marc Kleine-Budde @ 2013-12-21 21:32 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: Ezequiel Garcia, netdev, linux-can
[-- Attachment #1: Type: text/plain, Size: 1321 bytes --]
On 12/21/2013 11:16 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 12/22/2013 12:06 AM, Marc Kleine-Budde wrote:
>
>>>>> OMAP's ti_hecc driver is used to support the CAN controller on many
>>>>> omap2plus
>>>>> SoCs (OMAP2430, OMAP3, OMAP4, OMAP5 and AM335x), so it's wrong to
>>>>> make this
>>>>> depend on OMAP3 only. Take an extra step, to get wider build
>>>>> coverage, and make
>>>>> the driver depend on ARM.
>
>>>> To have a real wide coverage, it's probably worth adding '||
>>>> COMIPLE_TEXT'
>>>> to 'depends on ARCH_OMAP2PLUS'?
>
>>> Yup, and that was my exact proposal on my reply to v1 (which I forgot
>>> to detail
>>> in v2). I'd say it's Marc's call.
>
>> Convinced, I've added the v1 of this patch to can-next together with a
>> || COMIPLE_TEXT.
>
> Sorry, I meant COMPILE_TEST, of course. :-<
lol, I copy/pasted the || COMIPLE_TEXT from you, but in the patch I
added the correct COMPILE_TEST:
- depends on ARCH_OMAP3
+ depends on ARCH_OMAP2PLUS || COMPILE_TEST
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-12-21 21:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-20 20:14 [PATCH v2] can: ti_hecc: Replace platform dependency with ARM dependency Ezequiel Garcia
2013-12-20 21:17 ` Sergei Shtylyov
2013-12-20 21:33 ` Ezequiel Garcia
2013-12-21 21:06 ` Marc Kleine-Budde
2013-12-21 22:16 ` Sergei Shtylyov
2013-12-21 21:32 ` Marc Kleine-Budde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).