From: David Miller <davem@davemloft.net>
To: jhs@mojatatu.com
Cc: netdev@vger.kernel.org, xiyou.wangcong@gmail.com, eric.dumazet@gmail.com
Subject: Re: [Patch net-next] net_sched: act: Dont increment refcnt on replace
Date: Sun, 22 Dec 2013 17:50:15 -0500 (EST) [thread overview]
Message-ID: <20131222.175015.561115381077901987.davem@davemloft.net> (raw)
In-Reply-To: <52B6DC9B.9060309@mojatatu.com>
From: Jamal Hadi Salim <jhs@mojatatu.com>
Date: Sun, 22 Dec 2013 07:35:39 -0500
> This bug seems to have been around for some time, nothing to do with
> recent changes; i am just doing tests i havent run in a while and
> saw it. It is against net-next. If you think it is important enough,
> I could also create one against linus tree..
Jamal, I've tried to be patient with you over the years, but I really
need you to start submitting your changes more cleanly.
Your SUBJECT line MUST be the first line of the commit log message,
optionally with a prefix of the form "[PATCH xxx]" where "xxx" can
be "net", "net-next" and also contain versioning information such
as "v2" or "v3" etc.
Then your email message body must contain the commit message, with
no indentation whatsoever.
Then you may optionally provide a line with "---" then supplementary
information and text which you don't wish to end up in the final
commit message.
Then you provide the patch.
And this all must be inline and not as an attachment.
What I get from you is the output of "git show" as an attachment and I
absolutely cannot use that as-is. It idents the commit message,
amongst other things.
You can use "git format-patch" instead and munge it into a proper
email by hand. Unlike "git show", "git format-patch" won't indent
the commit message.
Please take a few moments to read other netdev patch postings
and see how regulars do it. They do what works for me.
Thank you.
next prev parent reply other threads:[~2013-12-22 22:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-22 12:35 [Patch net-next] net_sched: act: Dont increment refcnt on replace Jamal Hadi Salim
2013-12-22 22:50 ` David Miller [this message]
2013-12-23 13:07 ` Jamal Hadi Salim
2014-01-06 21:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131222.175015.561115381077901987.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).