* [PATCH net-next] sctp: remove casting from function calls through ops structure
@ 2013-12-18 9:18 Wang Weidong
2013-12-18 13:59 ` Neil Horman
2013-12-22 23:04 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Wang Weidong @ 2013-12-18 9:18 UTC (permalink / raw)
To: David Miller, Vlad Yasevich, Neil Horman; +Cc: netdev, linux-sctp
remove the unnecessary cast.
Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
---
net/sctp/output.c | 4 ++--
net/sctp/sm_sideeffect.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/sctp/output.c b/net/sctp/output.c
index 6371337..f4c1bd6 100644
--- a/net/sctp/output.c
+++ b/net/sctp/output.c
@@ -558,7 +558,7 @@ int sctp_packet_transmit(struct sctp_packet *packet)
* Note: The works for IPv6 layer checks this bit too later
* in transmission. See IP6_ECN_flow_xmit().
*/
- (*tp->af_specific->ecn_capable)(nskb->sk);
+ tp->af_specific->ecn_capable(nskb->sk);
/* Set up the IP options. */
/* BUG: not implemented
@@ -592,7 +592,7 @@ int sctp_packet_transmit(struct sctp_packet *packet)
pr_debug("***sctp_transmit_packet*** skb->len:%d\n", nskb->len);
nskb->local_df = packet->ipfragok;
- (*tp->af_specific->sctp_xmit)(nskb, tp);
+ tp->af_specific->sctp_xmit(nskb, tp);
out:
sctp_packet_reset(packet);
diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c
index 02b7ad1..2821dcb 100644
--- a/net/sctp/sm_sideeffect.c
+++ b/net/sctp/sm_sideeffect.c
@@ -1115,7 +1115,7 @@ int sctp_do_sm(struct net *net, sctp_event_t event_type, sctp_subtype_t subtype,
sctp_init_cmd_seq(&commands);
debug_pre_sfn();
- status = (*state_fn->fn)(net, ep, asoc, subtype, event_arg, &commands);
+ status = state_fn->fn(net, ep, asoc, subtype, event_arg, &commands);
debug_post_sfn();
error = sctp_side_effects(event_type, subtype, state,
--
1.7.12
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] sctp: remove casting from function calls through ops structure
2013-12-18 9:18 [PATCH net-next] sctp: remove casting from function calls through ops structure Wang Weidong
@ 2013-12-18 13:59 ` Neil Horman
2013-12-22 23:04 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Neil Horman @ 2013-12-18 13:59 UTC (permalink / raw)
To: Wang Weidong; +Cc: David Miller, Vlad Yasevich, netdev, linux-sctp
On Wed, Dec 18, 2013 at 05:18:55PM +0800, Wang Weidong wrote:
> remove the unnecessary cast.
>
> Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] sctp: remove casting from function calls through ops structure
2013-12-18 9:18 [PATCH net-next] sctp: remove casting from function calls through ops structure Wang Weidong
2013-12-18 13:59 ` Neil Horman
@ 2013-12-22 23:04 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2013-12-22 23:04 UTC (permalink / raw)
To: wangweidong1; +Cc: vyasevich, nhorman, netdev, linux-sctp
From: Wang Weidong <wangweidong1@huawei.com>
Date: Wed, 18 Dec 2013 17:18:55 +0800
> remove the unnecessary cast.
>
> Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-22 23:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-18 9:18 [PATCH net-next] sctp: remove casting from function calls through ops structure Wang Weidong
2013-12-18 13:59 ` Neil Horman
2013-12-22 23:04 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).