From: David Miller <davem@davemloft.net>
To: hannes@stressinduktion.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] ipv4: consistent reporting of pmtu data in case of corking
Date: Sun, 22 Dec 2013 18:52:34 -0500 (EST) [thread overview]
Message-ID: <20131222.185234.1072974003278388464.davem@davemloft.net> (raw)
In-Reply-To: <20131219011336.GB14429@order.stressinduktion.org>
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Thu, 19 Dec 2013 02:13:36 +0100
> We report different pmtu values back on the first write and on further
> writes on an corked socket.
>
> Also don't include the dst.header_len (respectively exthdrlen) as this
> should already be dealt with by the interface mtu of the outgoing
> (virtual) interface and policy of that interface should dictate if
> fragmentation should happen.
>
> Instead reduce the pmtu data by IP options as we do for IPv6. Make the
> same changes for ip_append_data, where we did not care about options or
> dst.header_len at all.
>
> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Looks good, applied, thanks.
prev parent reply other threads:[~2013-12-22 23:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 1:13 [PATCH net] ipv4: consistent reporting of pmtu data in case of corking Hannes Frederic Sowa
2013-12-22 23:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131222.185234.1072974003278388464.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).