From: David Miller <davem@davemloft.net>
To: antonio@meshcoding.com
Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
mareklindner@neomailbox.ch
Subject: Re: [PATCH 1/6] batman-adv: free nf_bridge member on locally delivered skb
Date: Sun, 22 Dec 2013 19:16:22 -0500 (EST) [thread overview]
Message-ID: <20131222.191622.118900475665948342.davem@davemloft.net> (raw)
In-Reply-To: <52B77F9E.8040201@meshcoding.com>
From: Antonio Quartulli <antonio@meshcoding.com>
Date: Mon, 23 Dec 2013 01:11:10 +0100
> Do you think it is safe to use nf_reset() directly?
If you do not know, you probably should not be making these
changes at all :-)
There is zero reason for your protocol layer to have an ad-hoc private
SKB netfilter state reset function that touches internals in this way.
At least with the generic helpers, we know the side effects and the
function is well known to other developers.
next prev parent reply other threads:[~2013-12-23 0:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 0:15 pull request [net]: batman-adv 2013-12-19 Antonio Quartulli
2013-12-19 0:15 ` [PATCH 1/6] batman-adv: free nf_bridge member on locally delivered skb Antonio Quartulli
2013-12-22 23:50 ` David Miller
2013-12-23 0:11 ` Antonio Quartulli
2013-12-23 0:16 ` David Miller [this message]
[not found] ` <20131222.191622.118900475665948342.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2013-12-23 0:19 ` Antonio Quartulli
2013-12-19 0:15 ` [PATCH 2/6] batman-adv: fix alignment for batadv_coded_packet Antonio Quartulli
2013-12-19 0:15 ` [PATCH 3/6] batman-adv: fix header alignment by unrolling batadv_header Antonio Quartulli
2013-12-19 0:15 ` [PATCH 4/6] batman-adv: fix size of batadv_icmp_header Antonio Quartulli
2013-12-19 0:15 ` [PATCH 5/6] batman-adv: fix size of batadv_bla_claim_dst Antonio Quartulli
2013-12-19 0:15 ` [PATCH 6/6] batman-adv: fix alignment for batadv_tvlv_tt_change Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131222.191622.118900475665948342.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=antonio@meshcoding.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=mareklindner@neomailbox.ch \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).