From: Dave Jones <davej@redhat.com>
To: netdev@vger.kernel.org
Cc: Dan Williams <dan.j.williams@intel.com>
Subject: Re: net_dma: mark broken
Date: Mon, 23 Dec 2013 11:21:13 -0500 [thread overview]
Message-ID: <20131223162113.GA20363@redhat.com> (raw)
In-Reply-To: <20131220211228.BC817660C74@gitolite.kernel.org>
On Fri, Dec 20, 2013 at 09:12:28PM +0000, Linux Kernel wrote:
> Gitweb: http://git.kernel.org/linus/;a=commit;h=77873803363c9e831fc1d1e6895c084279090c22
> Commit: 77873803363c9e831fc1d1e6895c084279090c22
> Parent: 0baf8f6a2ac86c2c40ed0cacab8ea3d17371a1bb
> Author: Dan Williams <dan.j.williams@intel.com>
> AuthorDate: Tue Dec 17 10:09:32 2013 -0800
> Committer: Dan Williams <dan.j.williams@intel.com>
> CommitDate: Wed Dec 18 12:53:43 2013 -0800
>
> net_dma: mark broken
>
> net_dma can cause data to be copied to a stale mapping if a
> copy-on-write fault occurs during dma. The application sees missing
> data.
Since this commit, coverity picked up a possible logic contradiction in tcp_rcv_established
Now that the only thing setting copied_early = 1 is inside an ifdef that won't be set,
it notes that this code is unreachable..
5271 if (!copied_early || tp->rcv_nxt != tp->rcv_wup)
5272 __tcp_ack_snd_check(sk, 0);
I don't understand all the subtleties of that huge function, so another
set of eyes would be appreciated. If it's a non-issue, I'll flag it as such
for coverity so it doesn't get picked up again.
Dave
next parent reply other threads:[~2013-12-23 16:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20131220211228.BC817660C74@gitolite.kernel.org>
2013-12-23 16:21 ` Dave Jones [this message]
2013-12-30 20:15 ` net_dma: mark broken Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131223162113.GA20363@redhat.com \
--to=davej@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).