* [PATCH net-next] hhf: make qdisc ops static
@ 2013-12-26 18:09 Stephen Hemminger
2013-12-26 18:30 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2013-12-26 18:09 UTC (permalink / raw)
To: Terry Lam, David Miller; +Cc: netdev
This module shouldn't be randomly exporting symbols
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
net/sched/sch_hhf.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/net/sched/sch_hhf.c 2013-12-24 15:14:54.398175948 -0800
+++ b/net/sched/sch_hhf.c 2013-12-24 15:16:02.409262185 -0800
@@ -711,7 +711,7 @@ static int hhf_dump_stats(struct Qdisc *
return gnet_stats_copy_app(d, &st, sizeof(st));
}
-struct Qdisc_ops hhf_qdisc_ops __read_mostly = {
+static struct Qdisc_ops hhf_qdisc_ops __read_mostly = {
.id = "hhf",
.priv_size = sizeof(struct hhf_sched_data),
@@ -727,7 +727,6 @@ struct Qdisc_ops hhf_qdisc_ops __read_mo
.dump_stats = hhf_dump_stats,
.owner = THIS_MODULE,
};
-EXPORT_SYMBOL(hhf_qdisc_ops);
static int __init hhf_module_init(void)
{
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] hhf: make qdisc ops static
2013-12-26 18:09 [PATCH net-next] hhf: make qdisc ops static Stephen Hemminger
@ 2013-12-26 18:30 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-12-26 18:30 UTC (permalink / raw)
To: stephen; +Cc: vtlam, netdev
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Thu, 26 Dec 2013 10:09:05 -0800
> This module shouldn't be randomly exporting symbols
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-12-26 18:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-26 18:09 [PATCH net-next] hhf: make qdisc ops static Stephen Hemminger
2013-12-26 18:30 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).