From: Stephen Hemminger <stephen@networkplumber.org>
To: Duan Jiong <duanj.fnst@cn.fujitsu.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH] ipv6: shouldn't dump the expired routes
Date: Thu, 26 Dec 2013 09:48:19 -0800 [thread overview]
Message-ID: <20131226094819.613cee5b@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <52BBC5F9.4050904@cn.fujitsu.com>
On Thu, 26 Dec 2013 14:00:25 +0800
Duan Jiong <duanj.fnst@cn.fujitsu.com> wrote:
>
> If we execute the command "ip -6 route show table all", those routes
> that have been expired will be dumped. But as everyone knows, those
> expired routes will not be used, and they will be deleted by the kernel.
> So why we still need to dump they, and just don't dump them.
>
> Signed-off-by: Duan Jiong <duanj.fnst@cn.fujitsu.com>
I can see three issues with this patch.
1. You are changing output of iproute2, and there is a slim chance somebody is
expecting those routes in some test script.
2. Developers maybe using this to check that the expiration of routes is really
working.
3. By making rt6_check_expired a global symbol, it can't be optimized as well in
a potentially hot path for routing.
I am not saying the patch shouldn't go in, just raising the possibility that such
a seemingly trivial change could cause other impacts.
next prev parent reply other threads:[~2013-12-26 17:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-26 6:00 [PATCH] ipv6: shouldn't dump the expired routes Duan Jiong
2013-12-26 17:48 ` Stephen Hemminger [this message]
2013-12-31 21:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131226094819.613cee5b@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=duanj.fnst@cn.fujitsu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).