From: Stephen Hemminger <stephen@networkplumber.org>
To: Ben Hutchings <bhutchings@solarflare.com>,
David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: [PATCH net-next] mdio: unused ethtool functions
Date: Thu, 26 Dec 2013 10:12:41 -0800 [thread overview]
Message-ID: <20131226101241.5f38e392@nehalam.linuxnetplumber.net> (raw)
Use it or lose it.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/mdio.c | 28 ----------------------------
include/linux/mdio.h | 3 ---
2 files changed, 31 deletions(-)
--- a/drivers/net/mdio.c 2013-12-24 15:37:35.779661759 -0800
+++ b/drivers/net/mdio.c 2013-12-24 15:38:26.054970175 -0800
@@ -342,34 +342,6 @@ void mdio45_ethtool_gset_npage(const str
EXPORT_SYMBOL(mdio45_ethtool_gset_npage);
/**
- * mdio45_ethtool_spauseparam_an - set auto-negotiated pause parameters
- * @mdio: MDIO interface
- * @ecmd: Ethtool request structure
- *
- * This function assumes that the PHY has an auto-negotiation MMD. It
- * will enable and disable advertising of flow control as appropriate.
- */
-void mdio45_ethtool_spauseparam_an(const struct mdio_if_info *mdio,
- const struct ethtool_pauseparam *ecmd)
-{
- int adv, old_adv;
-
- WARN_ON(!(mdio->mmds & MDIO_DEVS_AN));
-
- old_adv = mdio->mdio_read(mdio->dev, mdio->prtad, MDIO_MMD_AN,
- MDIO_AN_ADVERTISE);
- adv = ((old_adv & ~(ADVERTISE_PAUSE_CAP | ADVERTISE_PAUSE_ASYM)) |
- mii_advertise_flowctrl((ecmd->rx_pause ? FLOW_CTRL_RX : 0) |
- (ecmd->tx_pause ? FLOW_CTRL_TX : 0)));
- if (adv != old_adv) {
- mdio->mdio_write(mdio->dev, mdio->prtad, MDIO_MMD_AN,
- MDIO_AN_ADVERTISE, adv);
- mdio45_nway_restart(mdio);
- }
-}
-EXPORT_SYMBOL(mdio45_ethtool_spauseparam_an);
-
-/**
* mdio_mii_ioctl - MII ioctl interface for MDIO (clause 22 or 45) PHYs
* @mdio: MDIO interface
* @mii_data: MII ioctl data structure
--- a/include/linux/mdio.h 2013-12-24 15:37:35.779661759 -0800
+++ b/include/linux/mdio.h 2013-12-24 15:38:26.054970175 -0800
@@ -70,9 +70,6 @@ extern int mdio45_nway_restart(const str
extern void mdio45_ethtool_gset_npage(const struct mdio_if_info *mdio,
struct ethtool_cmd *ecmd,
u32 npage_adv, u32 npage_lpa);
-extern void
-mdio45_ethtool_spauseparam_an(const struct mdio_if_info *mdio,
- const struct ethtool_pauseparam *ecmd);
/**
* mdio45_ethtool_gset - get settings for ETHTOOL_GSET
next reply other threads:[~2013-12-26 18:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-26 18:12 Stephen Hemminger [this message]
2013-12-26 18:30 ` [PATCH net-next] mdio: unused ethtool functions David Miller
2013-12-27 9:06 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131226101241.5f38e392@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox