From: David Miller <davem@davemloft.net>
To: sergei.shtylyov@cogentembedded.com
Cc: f.fainelli@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] phy: IRQ cannot be shared
Date: Sun, 29 Dec 2013 22:35:44 -0500 (EST) [thread overview]
Message-ID: <20131229.223544.776831699070481195.davem@davemloft.net> (raw)
In-Reply-To: <52BDDAC4.2050100@cogentembedded.com>
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Fri, 27 Dec 2013 22:53:40 +0300
>> Arguably they are broken,
>
> Yes, they already are.
>
>> but they are least mostly working right now
>> and probes will completely fail after this change.
>
> I don't see how the probes will fail. Have you seen the surrounding
> code? It should just switch to PHY polling if request_irq() fails and
> return 0. Am I missing something?
Indeed, right you are.
Applied, thanks.
prev parent reply other threads:[~2013-12-30 3:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 19:09 [PATCH] phy: IRQ cannot be shared Sergei Shtylyov
2013-12-20 18:24 ` Florian Fainelli
2013-12-27 18:43 ` David Miller
2013-12-27 19:53 ` Sergei Shtylyov
2013-12-30 3:35 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131229.223544.776831699070481195.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).