From: David Miller <davem@davemloft.net>
To: dborkman@redhat.com
Cc: nicolas.dichtel@6wind.com, netdev@vger.kernel.org,
darkjames-ws@darkjames.pl
Subject: Re: [PATCH net-next v3 2/2] netlink: specify netlink packet direction for nlmon
Date: Tue, 31 Dec 2013 13:50:08 -0500 (EST) [thread overview]
Message-ID: <20131231.135008.1712348847039091134.davem@davemloft.net> (raw)
In-Reply-To: <52B878D7.4020308@redhat.com>
From: Daniel Borkmann <dborkman@redhat.com>
Date: Mon, 23 Dec 2013 18:54:31 +0100
> We could entirely remove it as it was e.g. proposed in 2008 [1]
> already if you see any value in that. Eventually it's up to Dave and
> if he likes, I'll be happy to send a patch that removes this define.
Removing user visible defines can break source builds, for example
someone building string tables or auto-generating things to facilitate
accessing these values from languages other than C.
It's harmless, since nobody semantically expects anything of it, but
we have to keep it around.
next prev parent reply other threads:[~2013-12-31 18:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 13:35 [PATCH net-next v3 0/2] nlmon updates Daniel Borkmann
2013-12-23 13:35 ` [PATCH net-next v3 1/2] netlink: only do not deliver to tap when both sides are kernel sks Daniel Borkmann
2013-12-23 13:35 ` [PATCH net-next v3 2/2] netlink: specify netlink packet direction for nlmon Daniel Borkmann
2013-12-23 17:46 ` Nicolas Dichtel
2013-12-23 17:54 ` Daniel Borkmann
2013-12-31 18:50 ` David Miller [this message]
2014-01-01 4:16 ` Daniel Borkmann
2013-12-31 19:32 ` [PATCH net-next v3 0/2] nlmon updates David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131231.135008.1712348847039091134.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=darkjames-ws@darkjames.pl \
--cc=dborkman@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).