From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: stephen@networkplumber.org, sathya.perla@emulex.com,
netdev@vger.kernel.org, edumazet@google.com
Subject: Re: [PATCH net-next] vxlan: distribute vxlan tunneled traffic across multiple TXQs
Date: Tue, 31 Dec 2013 13:56:36 -0500 (EST) [thread overview]
Message-ID: <20131231.135636.1587787263812667419.davem@davemloft.net> (raw)
In-Reply-To: <1387910346.12212.15.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 24 Dec 2013 10:39:06 -0800
> On Mon, 2013-12-23 at 11:28 -0800, Stephen Hemminger wrote:
>
>> The idea is good, but without the destructor there is nothing to keep
>> the UDP socket from being destroyed while packet is being sent on another
>> CPU.
>
> I see no requirement of holding a reference on the vxlan UDP socket in
> transmit path.
I'm trying to figure out how leaving a dangling socket attached to
skb->sk, as in this original patch, can be OK.
If skb->sk is there, anyone can reference it, and meanwhile anyone can
destroy and free it.
That's Stephens' objection.
Are you saying that we have something that allows this to be valid?
next prev parent reply other threads:[~2013-12-31 18:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 12:56 [PATCH net-next] vxlan: distribute vxlan tunneled traffic across multiple TXQs Sathya Perla
2013-12-23 19:28 ` Stephen Hemminger
2013-12-24 12:27 ` Sathya Perla
2013-12-24 18:39 ` Eric Dumazet
2013-12-24 23:05 ` Stephen Hemminger
2013-12-31 18:56 ` David Miller [this message]
2014-01-02 5:56 ` Eric Dumazet
2014-01-02 6:36 ` David Miller
2014-01-06 17:54 ` [PATCH net-next] vxlan: keep original skb ownership Eric Dumazet
2014-01-06 21:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131231.135636.1587787263812667419.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sathya.perla@emulex.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).