From: David Miller <davem@davemloft.net>
To: octavian.purdila@intel.com
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
hunold@linuxtv.org, jeroen@koekkoek.nl,
linux@rainbow-software.org, lkml20120218@newton.leun.net,
ming.lei@canonical.com
Subject: Re: [PATCH] usbnet: mcs7830: rework link state detection
Date: Tue, 31 Dec 2013 16:54:10 -0500 (EST) [thread overview]
Message-ID: <20131231.165410.1591097579937834027.davem@davemloft.net> (raw)
In-Reply-To: <1387818391-12935-1-git-send-email-octavian.purdila@intel.com>
From: Octavian Purdila <octavian.purdila@intel.com>
Date: Mon, 23 Dec 2013 19:06:31 +0200
> Even with the quirks in commit dabdaf0c (mcs7830: Fix link state
> detection) there are still spurious link-down events for some chips
> where the false link-down events count go over a few hundreds.
>
> This patch takes a more conservative approach and only looks at
> link-down events where the link-down state is not combined with other
> states (e.g. half/full speed, pending frames in SRAM or TX status
> information valid). In all other cases we assume the link is up.
>
> Tested on MCS7830CV-DA (USB ID 9710:7830).
>
> Cc: Ondrej Zary <linux@rainbow-software.org>
> Cc: Michael Leun <lkml20120218@newton.leun.net>
> Cc: Ming Lei <ming.lei@canonical.com>
> Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
Applied, thanks.
prev parent reply other threads:[~2013-12-31 21:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 17:06 [PATCH] usbnet: mcs7830: rework link state detection Octavian Purdila
2013-12-31 21:54 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131231.165410.1591097579937834027.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hunold@linuxtv.org \
--cc=jeroen@koekkoek.nl \
--cc=linux-usb@vger.kernel.org \
--cc=linux@rainbow-software.org \
--cc=lkml20120218@newton.leun.net \
--cc=ming.lei@canonical.com \
--cc=netdev@vger.kernel.org \
--cc=octavian.purdila@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).