From: David Miller <davem@davemloft.net>
To: dborkman@redhat.com
Cc: netdev@vger.kernel.org, stephen@networkplumber.org,
acme@ghostprotocols.net
Subject: Re: [PATCH net] net: llc: fix use after free in llc_ui_recvmsg
Date: Thu, 02 Jan 2014 19:31:55 -0500 (EST) [thread overview]
Message-ID: <20140102.193155.570848830875823542.davem@davemloft.net> (raw)
In-Reply-To: <1388443250-30224-1-git-send-email-dborkman@redhat.com>
From: Daniel Borkmann <dborkman@redhat.com>
Date: Mon, 30 Dec 2013 23:40:50 +0100
> While commit 30a584d944fb fixes datagram interface in LLC, a use
> after free bug has been introduced for SOCK_STREAM sockets that do
> not make use of MSG_PEEK.
>
> The flow is as follow ...
>
> if (!(flags & MSG_PEEK)) {
> ...
> sk_eat_skb(sk, skb, false);
> ...
> }
> ...
> if (used + offset < skb->len)
> continue;
>
> ... where sk_eat_skb() calls __kfree_skb(). Therefore, cache
> original length and work on skb_len to check partial reads.
>
> Fixes: 30a584d944fb ("[LLX]: SOCK_DGRAM interface fixes")
> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Applied and queued up for -stable, thanks!
prev parent reply other threads:[~2014-01-03 0:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-30 22:40 [PATCH net] net: llc: fix use after free in llc_ui_recvmsg Daniel Borkmann
2014-01-03 0:31 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140102.193155.570848830875823542.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=acme@ghostprotocols.net \
--cc=dborkman@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).