From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Paasch Subject: Re: [PATCH 3/4] tcp: metrics: Delete all entries matching a certain destination Date: Thu, 2 Jan 2014 10:18:23 +0100 Message-ID: <20140102091823.GA31178@cpaasch-mac> References: <1387109444-1104-1-git-send-email-christoph.paasch@uclouvain.be> <1387109444-1104-4-git-send-email-christoph.paasch@uclouvain.be> <20131217.145751.53681780657108721.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, ja@ssi.bg To: David Miller Return-path: Received: from smtp.sgsi.ucl.ac.be ([130.104.5.67]:51397 "EHLO smtp6.sgsi.ucl.ac.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751420AbaABJSb (ORCPT ); Thu, 2 Jan 2014 04:18:31 -0500 Content-Disposition: inline In-Reply-To: <20131217.145751.53681780657108721.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: Hello, On 17/12/13 - 14:57:51, David Miller wrote: > From: Christoph Paasch > Date: Sun, 15 Dec 2013 13:10:43 +0100 > > As we now can have multiple entries per destination-IP, the "ip > > tcp_metrics delete address ADDRESS" command should delete all of them. > > > > Signed-off-by: Christoph Paasch > > You have to adjust how you're doing patches #3 and #4. > > Create the new attribute for the source address first, then > allow the source address to be specified in the deletion > command. > > Make the source address optional in delete commands, to be > compatible with existing tools, and have it mean "ANY". I have to come back on this one. Can you explain what you mean by "ANY"? Do you mean that if no source-IP is given in the netlink command that all entries matching the dst should be deleted or rather only one of them (and that it would be non-deterministic which one)? Because, if I delete all of them, then "ip tcp_metrics flush PREFIX" of today's iproute2 will complain, because iproute2 expects that for each entry of "ip tcp_metrics show" a delete-call must be done. But, the non-deterministic case also feels a bit odd to me. Thanks, Christoph