From: Stephen Hemminger <stephen@networkplumber.org>
To: David Miller <davem@davemloft.net>
Cc: xiyou.wangcong@gmail.com, netdev@vger.kernel.org
Subject: Re: [Patch net-next] net: revert "sched classifier: make cgroup table local"
Date: Thu, 2 Jan 2014 17:21:10 -0800 [thread overview]
Message-ID: <20140102172110.38e0c473@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <20140102.190323.819558246638891031.davem@davemloft.net>
On Thu, 02 Jan 2014 19:03:23 -0500 (EST)
David Miller <davem@davemloft.net> wrote:
> From: Cong Wang <xiyou.wangcong@gmail.com>
> Date: Thu, 2 Jan 2014 14:58:41 -0800
>
> > This reverts commit de6fb288b1246a5c4e00c0cdbfe3a838a360b3f4.
> > Otherwise we got:
> >
> > net/sched/cls_cgroup.c:106:29: error: static declaration of ‘net_cls_subsys’ follows non-static declaration
> > static struct cgroup_subsys net_cls_subsys = {
> > ^
> > In file included from include/linux/cgroup.h:654:0,
> > from net/sched/cls_cgroup.c:18:
> > include/linux/cgroup_subsys.h:35:29: note: previous declaration of ‘net_cls_subsys’ was here
> > SUBSYS(net_cls)
> > ^
> > make[2]: *** [net/sched/cls_cgroup.o] Error 1
> >
> > Cc: Stephen Hemminger <stephen@networkplumber.org>
> > Cc: David S. Miller <davem@davemloft.net>
> > Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
>
> This is so damn unintuitive, and that build error only occurs if you
> build cls_cgroup statically.
>
> Applied, but the way this works is terrible.
Just removing from the include file is probably enough to fix it.
next prev parent reply other threads:[~2014-01-03 1:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-02 22:58 [Patch net-next] net: revert "sched classifier: make cgroup table local" Cong Wang
2014-01-03 0:03 ` David Miller
2014-01-03 1:21 ` Stephen Hemminger [this message]
2014-01-03 5:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140102172110.38e0c473@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).