From: David Miller <davem@davemloft.net>
To: jiang.biao2@zte.com.cn
Cc: bhutchings@solarflare.com, li.fengmao@zte.com.cn,
manish.chopra@qlogic.com, netdev@vger.kernel.org,
rajesh.borundia@qlogic.com, sony.chacko@qlogic.com,
wang.liang82@zte.com.cn, cai.qu@zte.com.cn, long.chun@zte.com.cn
Subject: Re: =?iso-2022-jp-3?B?GyRCRXobJChQJTsbKEI6?= Re: [Patch] netxen_nic: Bugfix for wrong RUNNING status of NX3031 NICs with no link
Date: Fri, 03 Jan 2014 02:18:31 -0500 (EST) [thread overview]
Message-ID: <20140103.021831.1305273132366498641.davem@davemloft.net> (raw)
In-Reply-To: <OF9AC42061.4BF09F2E-ON48257C55.00253C5A-48257C55.0027274D@zte.com.cn>
From: jiang.biao2@zte.com.cn
Date: Fri, 3 Jan 2014 15:07:27 +0800
> netif_carrier_off();
> netdev->operstate=IF_OPER_DOWN;
> register_netdevice();
This is too gross for words.
Stop fighting the way that device registraction and initial carrier
state works, please.
next prev parent reply other threads:[~2014-01-03 7:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-02 6:32 [Patch] netxen_nic: Bugfix for wrong RUNNING status of NX3031 NICs with no link jiang.biao2
2014-01-02 8:24 ` David Miller
2014-01-02 9:16 ` jiang.biao2
2014-01-02 18:00 ` Ben Hutchings
[not found] ` <OF9AC42061.4BF09F2E-ON48257C55.00253C5A-48257C55.0027274D@zte.com.cn>
2014-01-03 7:18 ` David Miller [this message]
2014-01-06 20:24 ` 答复: " Ben Hutchings
[not found] ` <OFB91B6321.D74C0B57-ON48257C54.00308F8C-48257C54.0030D7E7@zte.com.cn>
2014-01-02 17:33 ` =?iso-2022-jp-3?B?GyRCRXobJChQJTsbKEI6?= " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140103.021831.1305273132366498641.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=cai.qu@zte.com.cn \
--cc=jiang.biao2@zte.com.cn \
--cc=li.fengmao@zte.com.cn \
--cc=long.chun@zte.com.cn \
--cc=manish.chopra@qlogic.com \
--cc=netdev@vger.kernel.org \
--cc=rajesh.borundia@qlogic.com \
--cc=sony.chacko@qlogic.com \
--cc=wang.liang82@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox