From: David Miller <davem@davemloft.net>
To: xiyou.wangcong@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: unify the pcpu_tstats and br_cpu_netstats
Date: Fri, 03 Jan 2014 19:32:53 -0500 (EST) [thread overview]
Message-ID: <20140103.193253.2226162174184357030.davem@davemloft.net> (raw)
In-Reply-To: <slrnlccgj7.3uh.xiyou.wangcong@linux-6brj.site>
From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Fri, 3 Jan 2014 04:53:47 +0000 (UTC)
> On Thu, 02 Jan 2014 at 08:57 GMT, roy.qing.li@gmail.com <roy.qing.li@gmail.com> wrote:
>> From: Li RongQing <roy.qing.li@gmail.com>
>>
>> They are same, so unify them as one, pcpu_tstats.
>> and move pcpu_tstat into netdevice.h
>>
>
> tstats means Tunnel STATS, right? So, it has to be
> in if_tunnel.h.
They are being used in the bridging code now, did you read the
patch?
So not really limited to just tunnels, and therefore they really do
belong somewhere generic like netdevice.h
This also means that since they are now an encapsulation thing we
should rename them to pcpu_encap_stats or similar, thanks.
next prev parent reply other threads:[~2014-01-04 0:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-02 8:57 [PATCH net-next] net: unify the pcpu_tstats and br_cpu_netstats roy.qing.li
2014-01-03 4:53 ` Cong Wang
2014-01-04 0:32 ` David Miller [this message]
2014-01-04 0:43 ` Cong Wang
2014-01-04 0:46 ` David Miller
2014-01-04 0:47 ` Stephen Hemminger
2014-01-03 4:56 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140103.193253.2226162174184357030.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox