* [PATCH net-next] llc: make lock static
@ 2014-01-03 17:19 Stephen Hemminger
2014-01-04 1:57 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2014-01-03 17:19 UTC (permalink / raw)
To: David Miller; +Cc: netdev
The llc_sap_list_lock does not need to be global, only acquired
in core.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
--- a/include/net/llc.h 2013-12-30 21:34:18.438981005 -0800
+++ b/include/net/llc.h 2013-12-30 21:34:51.602557247 -0800
@@ -93,7 +93,6 @@ struct hlist_nulls_head *llc_sk_laddr_ha
#define LLC_DEST_CONN 2 /* Type 2 goes here */
extern struct list_head llc_sap_list;
-extern spinlock_t llc_sap_list_lock;
int llc_rcv(struct sk_buff *skb, struct net_device *dev, struct packet_type *pt,
struct net_device *orig_dev);
--- a/net/llc/llc_core.c 2013-12-30 21:34:18.438981005 -0800
+++ b/net/llc/llc_core.c 2013-12-30 21:34:51.602557247 -0800
@@ -23,7 +23,7 @@
#include <net/llc.h>
LIST_HEAD(llc_sap_list);
-DEFINE_SPINLOCK(llc_sap_list_lock);
+static DEFINE_SPINLOCK(llc_sap_list_lock);
/**
* llc_sap_alloc - allocates and initializes sap.
@@ -159,7 +159,6 @@ module_init(llc_init);
module_exit(llc_exit);
EXPORT_SYMBOL(llc_sap_list);
-EXPORT_SYMBOL(llc_sap_list_lock);
EXPORT_SYMBOL(llc_sap_find);
EXPORT_SYMBOL(llc_sap_open);
EXPORT_SYMBOL(llc_sap_close);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] llc: make lock static
2014-01-03 17:19 [PATCH net-next] llc: make lock static Stephen Hemminger
@ 2014-01-04 1:57 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-01-04 1:57 UTC (permalink / raw)
To: stephen; +Cc: netdev
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Fri, 3 Jan 2014 09:19:51 -0800
> The llc_sap_list_lock does not need to be global, only acquired
> in core.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-04 1:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-03 17:19 [PATCH net-next] llc: make lock static Stephen Hemminger
2014-01-04 1:57 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).