From: David Miller <davem@davemloft.net>
To: fw@strlen.de
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] macvlan: fix oops with vlan-on-top and HW_VLAN_CTAG_TX lowerdev
Date: Sat, 04 Jan 2014 20:13:33 -0500 (EST) [thread overview]
Message-ID: <20140104.201333.315186906532701163.davem@davemloft.net> (raw)
In-Reply-To: <20140104135132.GA2106@breakpoint.cc>
From: Florian Westphal <fw@strlen.de>
Date: Sat, 4 Jan 2014 14:51:32 +0100
> Archeology exercise #1 digs up 3b04ddde02c in linux.git, which
> creats header_ops->rebuild, from the old dev->rebuild_header.
>
> Exercise #2 then finds commit 275513d2e1c78 in netdev-vger-cvs.git tree.
> Quote from commit message:
>
> - dev->rebuild_header WILL DISAPPEAR. All the code
> relying on its existance is wrong, though still works.
>
> Alexey calling from 1997 ;-)
These protocols which use the broken ARP ops are special, the
problem is that they do things like send packets out when their
header ops are invoked.
It's non-trivial to undo this design, and these aren't easy protocols
to test.
That's why we've had this compat stuff for them for more than a
decade.
prev parent reply other threads:[~2014-01-05 1:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-28 13:38 [PATCH] macvlan: fix oops with vlan-on-top and HW_VLAN_CTAG_TX lowerdev Florian Westphal
2013-12-29 22:01 ` David Miller
2013-12-30 10:27 ` Florian Westphal
2013-12-31 21:24 ` David Miller
2014-01-03 11:39 ` Florian Westphal
2014-01-03 20:33 ` David Miller
2014-01-04 13:51 ` Florian Westphal
2014-01-05 1:13 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140104.201333.315186906532701163.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).