From: Stephen Hemminger <stephen@networkplumber.org>
To: Sabrina Dubroca <sd@queasysnail.net>
Cc: davem@davemloft.net, bhutchings@solarflare.com,
johannes@sipsolutions.net, netdev@vger.kernel.org
Subject: Re: [PATCH v2 3/5] alx: add stats update function
Date: Sat, 4 Jan 2014 14:16:08 -0800 [thread overview]
Message-ID: <20140104141608.5d882082@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1388854031-24142-4-git-send-email-sd@queasysnail.net>
On Sat, 4 Jan 2014 17:47:09 +0100
Sabrina Dubroca <sd@queasysnail.net> wrote:
> }
> +
> +void __alx_update_hw_stats(struct alx_hw *hw)
Minor NIT:
Why __ prefix? that is usually reserved for functions only
called from one file (or when wrapping an existing API)
next prev parent reply other threads:[~2014-01-04 22:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-04 16:47 [PATCH v2 0/5] alx: add statistics Sabrina Dubroca
2014-01-04 16:47 ` [PATCH v2 1/5] alx: add a hardware stats structure Sabrina Dubroca
2014-01-04 16:47 ` [PATCH v2 2/5] alx: add constants for the stats fields Sabrina Dubroca
2014-01-04 16:47 ` [PATCH v2 3/5] alx: add stats update function Sabrina Dubroca
2014-01-04 22:16 ` Stephen Hemminger [this message]
2014-01-04 23:16 ` Sabrina Dubroca
2014-01-04 16:47 ` [PATCH v2 4/5] alx: add alx_get_stats64 operation Sabrina Dubroca
2014-01-04 16:47 ` [PATCH v2 5/5] alx: add stats to ethtool Sabrina Dubroca
2014-01-06 9:03 ` Johannes Berg
2014-01-06 10:57 ` Sabrina Dubroca
2014-01-06 14:11 ` Johannes Berg
2014-01-06 14:56 ` Sabrina Dubroca
2014-01-06 15:16 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140104141608.5d882082@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).