From: David Miller <davem@davemloft.net>
To: hkchu@google.com
Cc: edumazet@google.com, herbert@gondor.apana.org.au,
ogerlitz@mellanox.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net-gre-gro: Add GRE support to the GRO stack
Date: Mon, 06 Jan 2014 15:43:30 -0500 (EST) [thread overview]
Message-ID: <20140106.154330.1324356005311602000.davem@davemloft.net> (raw)
In-Reply-To: <1388896679-23152-1-git-send-email-hkchu@google.com>
From: "H.K. Jerry Chu" <hkchu@google.com>
Date: Sat, 4 Jan 2014 20:37:59 -0800
> This patch built on top of Commit 299603e8370a93dd5d8e8d800f0dff1ce2c53d36
> ("net-gro: Prepare GRO stack for the upcoming tunneling support") to add
> the support of the standard GRE (RFC1701/RFC2784/RFC2890) to the GRO
> stack. It also serves as an example for supporting other encapsulation
> protocols in the GRO stack in the future.
...
Applied, but you guys do realize:
> diff --git a/net/ipv4/Makefile b/net/ipv4/Makefile
> index 4b81e91..f8c49ce 100644
> --- a/net/ipv4/Makefile
> +++ b/net/ipv4/Makefile
> @@ -11,7 +11,7 @@ obj-y := route.o inetpeer.o protocol.o \
> tcp_offload.o datagram.o raw.o udp.o udplite.o \
> udp_offload.o arp.o icmp.o devinet.o af_inet.o igmp.o \
> fib_frontend.o fib_semantics.o fib_trie.o \
> - inet_fragment.o ping.o ip_tunnel_core.o
> + inet_fragment.o ping.o ip_tunnel_core.o gre_offload.o
>
> obj-$(CONFIG_NET_IP_TUNNEL) += ip_tunnel.o
> obj-$(CONFIG_SYSCTL) += sysctl_net_ipv4.o
> @@ -19,7 +19,7 @@ obj-$(CONFIG_PROC_FS) += proc.o
> obj-$(CONFIG_IP_MULTIPLE_TABLES) += fib_rules.o
> obj-$(CONFIG_IP_MROUTE) += ipmr.o
> obj-$(CONFIG_NET_IPIP) += ipip.o
> -gre-y := gre_demux.o gre_offload.o
> +gre-y := gre_demux.o
> obj-$(CONFIG_NET_IPGRE_DEMUX) += gre.o
> obj-$(CONFIG_NET_IPGRE) += ip_gre.o
> obj-$(CONFIG_NET_IPVTI) += ip_vti.o
That the gre offload bits won't be registered unless GRE is enabled and
initialized/loaded, right?
next prev parent reply other threads:[~2014-01-06 20:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-05 4:37 [PATCH net-next] net-gre-gro: Add GRE support to the GRO stack H.K. Jerry Chu
2014-01-06 20:43 ` David Miller [this message]
2014-01-06 21:18 ` David Miller
2014-01-06 21:40 ` Eric Dumazet
2014-01-07 16:42 ` Jerry Chu
2014-01-06 22:03 ` [PATCH net-next] gre_offload: statically build GRE offloading support Eric Dumazet
2014-01-06 22:34 ` Eric Dumazet
2014-01-07 1:28 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2014-01-07 18:23 [PATCH net-next] net-gre-gro: Add GRE support to the GRO stack H.K. Jerry Chu
2014-01-07 21:22 ` David Miller
2014-01-07 22:55 ` Jerry Chu
2014-01-07 23:14 ` David Miller
2014-01-04 5:24 H.K. Jerry Chu
2014-01-05 1:09 ` David Miller
2014-01-05 1:33 ` Eric Dumazet
2014-01-05 4:00 ` Jerry Chu
2014-01-03 13:46 H.K. Jerry Chu
2014-01-04 1:51 ` David Miller
2014-01-04 5:20 ` Jerry Chu
2014-01-04 21:52 ` Stephen Hemminger
2014-01-04 4:00 ` Eric Dumazet
2013-12-30 17:14 H.K. Jerry Chu
2014-01-03 0:30 ` David Miller
2014-01-03 13:32 ` Jerry Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140106.154330.1324356005311602000.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=hkchu@google.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).