From: David Miller <davem@davemloft.net>
To: christoph.paasch@uclouvain.be
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, ja@ssi.bg
Subject: Re: [PATCH 3/4] tcp: metrics: Delete all entries matching a certain destination
Date: Mon, 06 Jan 2014 16:10:27 -0500 (EST) [thread overview]
Message-ID: <20140106.161027.1498450744291161306.davem@davemloft.net> (raw)
In-Reply-To: <20140102091823.GA31178@cpaasch-mac>
From: Christoph Paasch <christoph.paasch@uclouvain.be>
Date: Thu, 2 Jan 2014 10:18:23 +0100
> Do you mean that if no source-IP is given in the netlink command that all
> entries matching the dst should be deleted or rather only one of them (and that it
> would be non-deterministic which one)?
You would delete all of them, it's the only way to stay compatible with
the current code.
> Because, if I delete all of them, then "ip tcp_metrics flush PREFIX" of
> today's iproute2 will complain, because iproute2 expects that for each entry of
> "ip tcp_metrics show" a delete-call must be done.
>
> But, the non-deterministic case also feels a bit odd to me.
iproute2 should not expect that if it doesn't specify a specific
source address, in fact it doesn't even know how to currently. I
can't think of any other reasonable behavior.
next prev parent reply other threads:[~2014-01-06 21:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-15 12:10 [PATCH 0/4] Make tcp-metrics source-address aware Christoph Paasch
2013-12-15 12:10 ` [PATCH 1/4] tcp: metrics: rename tcpm_addr to tcpm_daddr Christoph Paasch
2013-12-15 12:10 ` [PATCH 2/4] tcp: metrics: Add source-address to tcp-metrics Christoph Paasch
2013-12-15 12:10 ` [PATCH 3/4] tcp: metrics: Delete all entries matching a certain destination Christoph Paasch
2013-12-17 19:57 ` David Miller
2013-12-18 9:58 ` Christoph Paasch
2014-01-02 9:18 ` Christoph Paasch
2014-01-06 21:10 ` David Miller [this message]
2013-12-15 12:10 ` [PATCH 4/4] tcp: metrics: Dump info of the source-address in netlink-reply Christoph Paasch
2013-12-15 18:40 ` [PATCH 0/4] Make tcp-metrics source-address aware Eric Dumazet
2013-12-16 18:45 ` Yuchung Cheng
2013-12-16 19:30 ` Christoph Paasch
2013-12-16 19:53 ` Yuchung Cheng
2013-12-16 20:01 ` Christoph Paasch
2013-12-17 19:56 ` David Miller
2013-12-16 1:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140106.161027.1498450744291161306.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=christoph.paasch@uclouvain.be \
--cc=eric.dumazet@gmail.com \
--cc=ja@ssi.bg \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).