* Re: mmotm 2014-01-02-14-35 uploaded (brocade/bna) [not found] <20140102223649.D8FB931C206@corp2gmr1-1.hot.corp.google.com> @ 2014-01-03 18:26 ` Randy Dunlap 2014-01-06 22:24 ` David Miller 0 siblings, 1 reply; 4+ messages in thread From: Randy Dunlap @ 2014-01-03 18:26 UTC (permalink / raw) To: akpm, Rasesh Mody, linux-kernel, netdev@vger.kernel.org, linux-next On 01/02/14 14:36, akpm@linux-foundation.org wrote: > The mm-of-the-moment snapshot 2014-01-02-14-35 has been uploaded to > > http://www.ozlabs.org/~akpm/mmotm/ > > mmotm-readme.txt says > > README for mm-of-the-moment: > > http://www.ozlabs.org/~akpm/mmotm/ > > This is a snapshot of my -mm patch queue. Uploaded at random hopefully > more than once a week. > on i386: as reported for linux-next of Dec.20, 2013 when CONFIG_NEED_DMA_MAP_STATE is not enabled: drivers/net/ethernet/brocade/bna/bnad.c: In function 'bnad_start_xmit': drivers/net/ethernet/brocade/bna/bnad.c:3074:26: error: 'struct bnad_tx_vector' has no member named 'dma_len' -- ~Randy ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: mmotm 2014-01-02-14-35 uploaded (brocade/bna) 2014-01-03 18:26 ` mmotm 2014-01-02-14-35 uploaded (brocade/bna) Randy Dunlap @ 2014-01-06 22:24 ` David Miller 2014-01-07 1:38 ` David Miller 0 siblings, 1 reply; 4+ messages in thread From: David Miller @ 2014-01-06 22:24 UTC (permalink / raw) To: rdunlap; +Cc: akpm, rmody, linux-kernel, netdev, linux-next From: Randy Dunlap <rdunlap@infradead.org> Date: Fri, 03 Jan 2014 10:26:01 -0800 > as reported for linux-next of Dec.20, 2013 > when CONFIG_NEED_DMA_MAP_STATE is not enabled: > > drivers/net/ethernet/brocade/bna/bnad.c: In function 'bnad_start_xmit': > drivers/net/ethernet/brocade/bna/bnad.c:3074:26: error: 'struct bnad_tx_vector' has no member named 'dma_len' Sorry for taking so long, I plan to look into this tonight Randy. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: mmotm 2014-01-02-14-35 uploaded (brocade/bna) 2014-01-06 22:24 ` David Miller @ 2014-01-07 1:38 ` David Miller 2014-01-07 1:58 ` Randy Dunlap 0 siblings, 1 reply; 4+ messages in thread From: David Miller @ 2014-01-07 1:38 UTC (permalink / raw) To: rdunlap; +Cc: akpm, rmody, linux-kernel, netdev, linux-next From: David Miller <davem@davemloft.net> Date: Mon, 06 Jan 2014 17:24:27 -0500 (EST) > From: Randy Dunlap <rdunlap@infradead.org> > Date: Fri, 03 Jan 2014 10:26:01 -0800 > >> as reported for linux-next of Dec.20, 2013 >> when CONFIG_NEED_DMA_MAP_STATE is not enabled: >> >> drivers/net/ethernet/brocade/bna/bnad.c: In function 'bnad_start_xmit': >> drivers/net/ethernet/brocade/bna/bnad.c:3074:26: error: 'struct bnad_tx_vector' has no member named 'dma_len' > > Sorry for taking so long, I plan to look into this tonight Randy. I just committed the following fix for this, thanks! ==================== [PATCH] bna: Fix build due to missing use of dma_unmap_len_set() > as reported for linux-next of Dec.20, 2013 > when CONFIG_NEED_DMA_MAP_STATE is not enabled: > > drivers/net/ethernet/brocade/bna/bnad.c: In function 'bnad_start_xmit': > drivers/net/ethernet/brocade/bna/bnad.c:3074:26: error: 'struct bnad_tx_vector' has no member named 'dma_len' Reported-by: Randy Dunlap <rdunlap@infradead.org> Signed-off-by: David S. Miller <davem@davemloft.net> --- drivers/net/ethernet/brocade/bna/bnad.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/brocade/bna/bnad.c b/drivers/net/ethernet/brocade/bna/bnad.c index d31524f..5f24a9f 100644 --- a/drivers/net/ethernet/brocade/bna/bnad.c +++ b/drivers/net/ethernet/brocade/bna/bnad.c @@ -3071,11 +3071,11 @@ bnad_start_xmit(struct sk_buff *skb, struct net_device *netdev) dma_addr = skb_frag_dma_map(&bnad->pcidev->dev, frag, 0, size, DMA_TO_DEVICE); - unmap->vectors[vect_id].dma_len = size; + dma_unmap_len_set(&unmap->vectors[vect_id], dma_len, size); BNA_SET_DMA_ADDR(dma_addr, &txqent->vector[vect_id].host_addr); txqent->vector[vect_id].length = htons(size); dma_unmap_addr_set(&unmap->vectors[vect_id], dma_addr, - dma_addr); + dma_addr); head_unmap->nvecs++; } -- 1.7.11.7 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: mmotm 2014-01-02-14-35 uploaded (brocade/bna) 2014-01-07 1:38 ` David Miller @ 2014-01-07 1:58 ` Randy Dunlap 0 siblings, 0 replies; 4+ messages in thread From: Randy Dunlap @ 2014-01-07 1:58 UTC (permalink / raw) To: David Miller; +Cc: akpm, rmody, linux-kernel, netdev, linux-next On 01/06/14 17:38, David Miller wrote: > From: David Miller <davem@davemloft.net> > Date: Mon, 06 Jan 2014 17:24:27 -0500 (EST) > >> From: Randy Dunlap <rdunlap@infradead.org> >> Date: Fri, 03 Jan 2014 10:26:01 -0800 >> >>> as reported for linux-next of Dec.20, 2013 >>> when CONFIG_NEED_DMA_MAP_STATE is not enabled: >>> >>> drivers/net/ethernet/brocade/bna/bnad.c: In function 'bnad_start_xmit': >>> drivers/net/ethernet/brocade/bna/bnad.c:3074:26: error: 'struct bnad_tx_vector' has no member named 'dma_len' >> >> Sorry for taking so long, I plan to look into this tonight Randy. > > I just committed the following fix for this, thanks! > Acked-by: Randy Dunlap <rdunlap@infradead.org> Thanks, Dave. > ==================== > [PATCH] bna: Fix build due to missing use of dma_unmap_len_set() > >> as reported for linux-next of Dec.20, 2013 >> when CONFIG_NEED_DMA_MAP_STATE is not enabled: >> >> drivers/net/ethernet/brocade/bna/bnad.c: In function 'bnad_start_xmit': >> drivers/net/ethernet/brocade/bna/bnad.c:3074:26: error: 'struct bnad_tx_vector' has no member named 'dma_len' > > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Signed-off-by: David S. Miller <davem@davemloft.net> > --- > drivers/net/ethernet/brocade/bna/bnad.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/brocade/bna/bnad.c b/drivers/net/ethernet/brocade/bna/bnad.c > index d31524f..5f24a9f 100644 > --- a/drivers/net/ethernet/brocade/bna/bnad.c > +++ b/drivers/net/ethernet/brocade/bna/bnad.c > @@ -3071,11 +3071,11 @@ bnad_start_xmit(struct sk_buff *skb, struct net_device *netdev) > > dma_addr = skb_frag_dma_map(&bnad->pcidev->dev, frag, > 0, size, DMA_TO_DEVICE); > - unmap->vectors[vect_id].dma_len = size; > + dma_unmap_len_set(&unmap->vectors[vect_id], dma_len, size); > BNA_SET_DMA_ADDR(dma_addr, &txqent->vector[vect_id].host_addr); > txqent->vector[vect_id].length = htons(size); > dma_unmap_addr_set(&unmap->vectors[vect_id], dma_addr, > - dma_addr); > + dma_addr); > head_unmap->nvecs++; > } > > -- ~Randy ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-01-07 1:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20140102223649.D8FB931C206@corp2gmr1-1.hot.corp.google.com>
2014-01-03 18:26 ` mmotm 2014-01-02-14-35 uploaded (brocade/bna) Randy Dunlap
2014-01-06 22:24 ` David Miller
2014-01-07 1:38 ` David Miller
2014-01-07 1:58 ` Randy Dunlap
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).