From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Frederic Sowa Subject: Re: [PATCH net-next 1/2] ipv4: add forwarding_uses_pmtu knob to protect forward path to use pmtu info Date: Mon, 6 Jan 2014 14:29:04 +0100 Message-ID: <20140106132904.GD4611@order.stressinduktion.org> References: <20131220130822.GD32129@order.stressinduktion.org> <20131231042840.GC27636@order.stressinduktion.org> <20140106090521.GQ31491@secunet.com> <20140106131822.GU31491@secunet.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, davem@davemloft.net To: Steffen Klassert Return-path: Received: from order.stressinduktion.org ([87.106.68.36]:42150 "EHLO order.stressinduktion.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750990AbaAFN3F (ORCPT ); Mon, 6 Jan 2014 08:29:05 -0500 Content-Disposition: inline In-Reply-To: <20140106131822.GU31491@secunet.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Jan 06, 2014 at 02:18:22PM +0100, Steffen Klassert wrote: > On Mon, Jan 06, 2014 at 10:05:21AM +0100, Steffen Klassert wrote: > > > > > > IIRC you have a (semi-)automatic test suite to test for (p)mtu problems? Would > > > these checks cover such a change? > > > > > > > I'm currenlty testing these patches. ipv4 looks good but on > > ipv6 with 'ping6' the packet size is not reduced according > > to the pmtu when forward_use_pmtu is set to 0. > > > > I'll run the tests again with your updated v3 patches. > > > > The v3 version of your patches don't show any obvious regressions > on our pmtu test suite. I am happy to hear that. Thanks again for testing!