From: David Miller <davem@davemloft.net>
To: shh.xie@gmail.com
Cc: jg1.han@samsung.com, mugunthanvnm@ti.com, f.fainelli@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Shaohui.Xie@freescale.com, afleming@gmail.com
Subject: Re: [PATCH 5/6] [v4] phylib: Support attaching to generic 10g driver
Date: Tue, 07 Jan 2014 00:56:07 -0500 (EST) [thread overview]
Message-ID: <20140107.005607.716747884959539511.davem@davemloft.net> (raw)
In-Reply-To: <1389060865-7143-1-git-send-email-shh.xie@gmail.com>
From: <shh.xie@gmail.com>
Date: Tue, 7 Jan 2014 10:14:25 +0800
> -static int phy_attach_direct(struct net_device *dev, struct phy_device *phydev,
> +int phy_attach_direct(struct net_device *dev, struct phy_device *phydev,
> u32 flags, phy_interface_t interface)
Since you are changing where the open parenthesis is, you must reindent
the arguments on the second line so that they start exactly at the
first column after that openning parenthesis.
next prev parent reply other threads:[~2014-01-07 5:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 2:14 [PATCH 5/6] [v4] phylib: Support attaching to generic 10g driver shh.xie
2014-01-07 5:56 ` David Miller [this message]
2014-01-07 7:04 ` Shaohui Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140107.005607.716747884959539511.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Shaohui.Xie@freescale.com \
--cc=afleming@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=jg1.han@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=shh.xie@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox