From: David Miller <davem@davemloft.net>
To: horms+renesas@verge.net.au
Cc: netdev@vger.kernel.org, linux-sh@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, magnus.damm@gmail.com,
sergei.shtylyov@cogentembedded.com
Subject: Re: [PATCH v3 net-next 1/3] sh_eth: Add support for r7s72100
Date: Tue, 07 Jan 2014 14:07:55 -0500 (EST) [thread overview]
Message-ID: <20140107.140755.1722284527902829385.davem@davemloft.net> (raw)
In-Reply-To: <1389061635-4083-2-git-send-email-horms+renesas@verge.net.au>
From: Simon Horman <horms+renesas@verge.net.au>
Date: Tue, 7 Jan 2014 11:27:13 +0900
> @@ -318,6 +371,14 @@ static int sh_eth_is_gether(struct sh_eth_private *mdp)
> return 0;
> }
>
> +static int sh_eth_is_rz_fast_ether(struct sh_eth_private *mdp)
> +{
> + if (mdp->reg_offset == sh_eth_offset_fast_rz)
> + return 1;
> + else
> + return 0;
> +}
Please make this return a boolean and use true/false.
> @@ -2061,6 +2155,10 @@ static struct net_device_stats *sh_eth_get_stats(struct net_device *ndev)
> {
> struct sh_eth_private *mdp = netdev_priv(ndev);
>
> + if (sh_eth_is_rz_fast_ether(mdp)) {
> + return &ndev->stats;
> + }
Single statement basic blocks do not need curly braces, therefore
please remove them here.
THanks.
next prev parent reply other threads:[~2014-01-07 19:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 2:27 [PATCH v3 0/3] Add ethernet support for r7s72100 Simon Horman
2014-01-07 2:27 ` [PATCH v3 net-next 1/3] sh_eth: Add " Simon Horman
2014-01-07 19:07 ` David Miller [this message]
2014-01-08 0:06 ` Simon Horman
2014-01-07 2:27 ` [PATCH v3 2/3] ARM: shmobile: r7s72100: Add clock for r7s72100-ether Simon Horman
2014-01-07 2:27 ` [PATCH v3 3/3] ARM: shmobile: genmai: Enable r7s72100-ether Simon Horman
2014-01-07 22:13 ` Sergei Shtylyov
2014-01-08 0:07 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140107.140755.1722284527902829385.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=horms+renesas@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).