* [PATCH -next] net/mlx4_en: fix error return code in mlx4_en_get_qp()
@ 2014-01-07 8:56 Wei Yongjun
2014-01-07 20:43 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Wei Yongjun @ 2014-01-07 8:56 UTC (permalink / raw)
To: amirv, ogerlitz, davem; +Cc: yongjun_wei, netdev
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fix to return a negative error code from the error handling
case instead of 0.
Fixes: 837052d0ccc5 ('net/mlx4_en: Add netdev support for TCP/IP offloads of vxlan tunneling')
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
index 60b927e..fad4531 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
@@ -632,8 +632,9 @@ static int mlx4_en_get_qp(struct mlx4_en_priv *priv)
if (err)
goto steer_err;
- if (mlx4_en_tunnel_steer_add(priv, priv->dev->dev_addr, *qpn,
- &priv->tunnel_reg_id))
+ err = mlx4_en_tunnel_steer_add(priv, priv->dev->dev_addr, *qpn,
+ &priv->tunnel_reg_id);
+ if (err)
goto tunnel_err;
entry = kmalloc(sizeof(*entry), GFP_KERNEL);
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] net/mlx4_en: fix error return code in mlx4_en_get_qp()
2014-01-07 8:56 [PATCH -next] net/mlx4_en: fix error return code in mlx4_en_get_qp() Wei Yongjun
@ 2014-01-07 20:43 ` David Miller
2014-01-08 9:40 ` Or Gerlitz
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2014-01-07 20:43 UTC (permalink / raw)
To: weiyj.lk; +Cc: amirv, ogerlitz, yongjun_wei, netdev
From: Wei Yongjun <weiyj.lk@gmail.com>
Date: Tue, 7 Jan 2014 16:56:07 +0800
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return a negative error code from the error handling
> case instead of 0.
>
> Fixes: 837052d0ccc5 ('net/mlx4_en: Add netdev support for TCP/IP offloads of vxlan tunneling')
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Looks good, applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] net/mlx4_en: fix error return code in mlx4_en_get_qp()
2014-01-07 20:43 ` David Miller
@ 2014-01-08 9:40 ` Or Gerlitz
0 siblings, 0 replies; 3+ messages in thread
From: Or Gerlitz @ 2014-01-08 9:40 UTC (permalink / raw)
To: weiyj.lk; +Cc: David Miller, amirv, yongjun_wei, netdev
On 07/01/2014 22:43, David Miller wrote:
> From: Wei Yongjun <weiyj.lk@gmail.com>
> Date: Tue, 7 Jan 2014 16:56:07 +0800
>
>> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>>
>> Fix to return a negative error code from the error handling
>> case instead of 0.
>>
>> Fixes: 837052d0ccc5 ('net/mlx4_en: Add netdev support for TCP/IP offloads of vxlan tunneling')
>> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> Looks good, applied, thanks.
Indeed, thanks for spotting and fixing.
Or.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-08 9:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-07 8:56 [PATCH -next] net/mlx4_en: fix error return code in mlx4_en_get_qp() Wei Yongjun
2014-01-07 20:43 ` David Miller
2014-01-08 9:40 ` Or Gerlitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).