From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] bnx2x: prevent WARN during driver unload Date: Tue, 07 Jan 2014 15:45:46 -0500 (EST) Message-ID: <20140107.154546.297973917685156649.davem@davemloft.net> References: <1389089261-25714-1-git-send-email-yuvalmin@broadcom.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, dmitry@broadcom.com, ariele@broadcom.com To: yuvalmin@broadcom.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:44508 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751114AbaAGUps (ORCPT ); Tue, 7 Jan 2014 15:45:48 -0500 In-Reply-To: <1389089261-25714-1-git-send-email-yuvalmin@broadcom.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Yuval Mintz Date: Tue, 7 Jan 2014 12:07:41 +0200 > + fp->state &= BNX2X_FP_STATE_DISABLED; ... > + fp->state &= BNX2X_FP_STATE_DISABLED; Surely you mean "&= ~BNX2X_FP_STATE_DISABLED" here?