From: David Miller <davem@davemloft.net>
To: bpoirier@suse.de
Cc: edumazet@google.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, therbert@google.com
Subject: Re: [PATCH v2] net: Do not enable tx-nocache-copy by default
Date: Tue, 07 Jan 2014 16:20:53 -0500 (EST) [thread overview]
Message-ID: <20140107.162053.1127386147694253061.davem@davemloft.net> (raw)
In-Reply-To: <1389107470-18213-1-git-send-email-bpoirier@suse.de>
From: Benjamin Poirier <bpoirier@suse.de>
Date: Tue, 7 Jan 2014 10:11:10 -0500
> There are many cases where this feature does not improve performance or even
> reduces it.
>
> For example, here are the results from tests that I've run using 3.12.6 on one
> Intel Xeon W3565 and one i7 920 connected by ixgbe adapters. The results are
> from the Xeon, but they're similar on the i7. All numbers report the
> mean±stddev over 10 runs of 10s.
>
> 1) latency tests similar to what is described in "c6e1a0d net: Allow no-cache
> copy from user on transmit"
> There is no statistically significant difference between tx-nocache-copy
> on/off.
> nic irqs spread out (one queue per cpu)
...
> CC: Tom Herbert <therbert@google.com>
> Signed-off-by: Benjamin Poirier <bpoirier@suse.de>
Looks good, applied, thanks.
next prev parent reply other threads:[~2014-01-07 21:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-06 20:27 tx-nocache-copy performance Benjamin Poirier
2014-01-06 20:57 ` Eric Dumazet
2014-01-06 21:13 ` Eric Dumazet
2014-01-06 23:20 ` [PATCH] net: Do not enable tx-nocache-copy by default Benjamin Poirier
2014-01-07 1:00 ` David Miller
2014-01-07 15:11 ` [PATCH v2] " Benjamin Poirier
2014-01-07 21:20 ` David Miller [this message]
2014-01-06 20:59 ` tx-nocache-copy performance Tom Herbert
2014-01-06 21:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140107.162053.1127386147694253061.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bpoirier@suse.de \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).