netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: shawn.bohrer@gmail.com
Cc: ogerlitz@mellanox.com, amirv@mellanox.com,
	richardcochran@gmail.com, netdev@vger.kernel.org,
	tomk@rgmadvisors.com, hadarh@mellanox.com,
	sbohrer@rgmadvisors.com
Subject: Re: [PATCH] mlx4_en: Select PTP_1588_CLOCK
Date: Tue, 07 Jan 2014 16:24:03 -0500 (EST)	[thread overview]
Message-ID: <20140107.162403.271069132339632530.davem@davemloft.net> (raw)
In-Reply-To: <1389120557-6773-1-git-send-email-shawn.bohrer@gmail.com>

From: Shawn Bohrer <shawn.bohrer@gmail.com>
Date: Tue,  7 Jan 2014 12:49:17 -0600

> From: Shawn Bohrer <sbohrer@rgmadvisors.com>
> 
> Now that mlx4_en includes a PHC driver it must select PTP_1588_CLOCK.
> 
>    drivers/built-in.o: In function `mlx4_en_get_ts_info':
>>> en_ethtool.c:(.text+0x391a11): undefined reference to `ptp_clock_index'
>    drivers/built-in.o: In function `mlx4_en_remove_timestamp':
>>> (.text+0x397913): undefined reference to `ptp_clock_unregister'
>    drivers/built-in.o: In function `mlx4_en_init_timestamp':
>>> (.text+0x397b20): undefined reference to `ptp_clock_register'
> 
> Fixes: ad7d4eaed995d ("mlx4_en: Add PTP hardware clock")
> Signed-off-by: Shawn Bohrer <sbohrer@rgmadvisors.com>

Looks good, applied, thanks.

      parent reply	other threads:[~2014-01-07 21:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-07 18:49 [PATCH] mlx4_en: Select PTP_1588_CLOCK Shawn Bohrer
2014-01-07 18:57 ` Shawn Bohrer
2014-01-07 21:24 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140107.162403.271069132339632530.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=amirv@mellanox.com \
    --cc=hadarh@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    --cc=richardcochran@gmail.com \
    --cc=sbohrer@rgmadvisors.com \
    --cc=shawn.bohrer@gmail.com \
    --cc=tomk@rgmadvisors.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).