* [PATCH] mlx4_en: Select PTP_1588_CLOCK
@ 2014-01-07 18:49 Shawn Bohrer
2014-01-07 18:57 ` Shawn Bohrer
2014-01-07 21:24 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Shawn Bohrer @ 2014-01-07 18:49 UTC (permalink / raw)
To: David S. Miller
Cc: Or Gerlitz, Amir Vadai, Richard Cochran, netdev, tomk,
Hadar Hen Zion, Shawn Bohrer
From: Shawn Bohrer <sbohrer@rgmadvisors.com>
Now that mlx4_en includes a PHC driver it must select PTP_1588_CLOCK.
drivers/built-in.o: In function `mlx4_en_get_ts_info':
>> en_ethtool.c:(.text+0x391a11): undefined reference to `ptp_clock_index'
drivers/built-in.o: In function `mlx4_en_remove_timestamp':
>> (.text+0x397913): undefined reference to `ptp_clock_unregister'
drivers/built-in.o: In function `mlx4_en_init_timestamp':
>> (.text+0x397b20): undefined reference to `ptp_clock_register'
Fixes: ad7d4eaed995d ("mlx4_en: Add PTP hardware clock")
Signed-off-by: Shawn Bohrer <sbohrer@rgmadvisors.com>
---
drivers/net/ethernet/mellanox/mlx4/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/Kconfig b/drivers/net/ethernet/mellanox/mlx4/Kconfig
index eb520ab..563495d 100644
--- a/drivers/net/ethernet/mellanox/mlx4/Kconfig
+++ b/drivers/net/ethernet/mellanox/mlx4/Kconfig
@@ -6,6 +6,7 @@ config MLX4_EN
tristate "Mellanox Technologies 10Gbit Ethernet support"
depends on PCI
select MLX4_CORE
+ select PTP_1588_CLOCK
---help---
This driver supports Mellanox Technologies ConnectX Ethernet
devices.
--
1.7.7.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mlx4_en: Select PTP_1588_CLOCK
2014-01-07 18:49 [PATCH] mlx4_en: Select PTP_1588_CLOCK Shawn Bohrer
@ 2014-01-07 18:57 ` Shawn Bohrer
2014-01-07 21:24 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Bohrer @ 2014-01-07 18:57 UTC (permalink / raw)
To: David S. Miller
Cc: Or Gerlitz, Amir Vadai, Richard Cochran, netdev, tomk,
Hadar Hen Zion, Shawn Bohrer
On Tue, Jan 07, 2014 at 12:49:17PM -0600, Shawn Bohrer wrote:
> From: Shawn Bohrer <sbohrer@rgmadvisors.com>
>
> Now that mlx4_en includes a PHC driver it must select PTP_1588_CLOCK.
>
> drivers/built-in.o: In function `mlx4_en_get_ts_info':
> >> en_ethtool.c:(.text+0x391a11): undefined reference to `ptp_clock_index'
> drivers/built-in.o: In function `mlx4_en_remove_timestamp':
> >> (.text+0x397913): undefined reference to `ptp_clock_unregister'
> drivers/built-in.o: In function `mlx4_en_init_timestamp':
> >> (.text+0x397b20): undefined reference to `ptp_clock_register'
>
> Fixes: ad7d4eaed995d ("mlx4_en: Add PTP hardware clock")
> Signed-off-by: Shawn Bohrer <sbohrer@rgmadvisors.com>
Sorry forgot to add this is against net-next.
--
Shawn
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mlx4_en: Select PTP_1588_CLOCK
2014-01-07 18:49 [PATCH] mlx4_en: Select PTP_1588_CLOCK Shawn Bohrer
2014-01-07 18:57 ` Shawn Bohrer
@ 2014-01-07 21:24 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-01-07 21:24 UTC (permalink / raw)
To: shawn.bohrer
Cc: ogerlitz, amirv, richardcochran, netdev, tomk, hadarh, sbohrer
From: Shawn Bohrer <shawn.bohrer@gmail.com>
Date: Tue, 7 Jan 2014 12:49:17 -0600
> From: Shawn Bohrer <sbohrer@rgmadvisors.com>
>
> Now that mlx4_en includes a PHC driver it must select PTP_1588_CLOCK.
>
> drivers/built-in.o: In function `mlx4_en_get_ts_info':
>>> en_ethtool.c:(.text+0x391a11): undefined reference to `ptp_clock_index'
> drivers/built-in.o: In function `mlx4_en_remove_timestamp':
>>> (.text+0x397913): undefined reference to `ptp_clock_unregister'
> drivers/built-in.o: In function `mlx4_en_init_timestamp':
>>> (.text+0x397b20): undefined reference to `ptp_clock_register'
>
> Fixes: ad7d4eaed995d ("mlx4_en: Add PTP hardware clock")
> Signed-off-by: Shawn Bohrer <sbohrer@rgmadvisors.com>
Looks good, applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-07 21:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-07 18:49 [PATCH] mlx4_en: Select PTP_1588_CLOCK Shawn Bohrer
2014-01-07 18:57 ` Shawn Bohrer
2014-01-07 21:24 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).