From: David Miller <davem@davemloft.net>
To: paul.durrant@citrix.com
Cc: netdev@vger.kernel.org, xen-devel@lists.xen.org,
wei.liu2@citrix.com, ian.campbell@citrix.com,
david.vrabel@citrix.com
Subject: Re: [PATCH net-next] xen-netback: stop vif thread spinning if frontend is unresponsive
Date: Tue, 07 Jan 2014 16:29:56 -0500 (EST) [thread overview]
Message-ID: <20140107.162956.1062166230525232035.davem@davemloft.net> (raw)
In-Reply-To: <1389111929-37231-1-git-send-email-paul.durrant@citrix.com>
From: Paul Durrant <paul.durrant@citrix.com>
Date: Tue, 7 Jan 2014 16:25:29 +0000
> @@ -477,6 +477,7 @@ static void xenvif_rx_action(struct xenvif *vif)
> unsigned long offset;
> struct skb_cb_overlay *sco;
> int need_to_notify = 0;
> + int ring_full = 0;
Please use bool, false, and true.
>
> - if (!npo.copy_prod)
> + if (!npo.copy_prod) {
> + if (ring_full)
> + vif->rx_queue_stopped = true;
> goto done;
> + }
> +
> + vif->rx_queue_stopped = false;
And then you can code this as:
vif->rx_queue_stopped = (!npo.copy_prod && ring_full);
if (!npo.copy_prod)
goto done;
next prev parent reply other threads:[~2014-01-07 21:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 16:25 [PATCH net-next] xen-netback: stop vif thread spinning if frontend is unresponsive Paul Durrant
2014-01-07 21:29 ` David Miller [this message]
2014-01-08 9:49 ` Paul Durrant
2014-01-08 9:55 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140107.162956.1062166230525232035.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david.vrabel@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=netdev@vger.kernel.org \
--cc=paul.durrant@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox