From: David Miller <davem@davemloft.net>
To: majieyue@gmail.com
Cc: netdev@vger.kernel.org, xen-devel@lists.xen.org,
jieyue.majy@alibaba-inc.com, yingbin.wangyb@alibaba-inc.com,
tienan.ftn@alibaba-inc.com, wei.liu2@citrix.com,
ian.campbell@citrix.com, david.vrabel@citrix.com
Subject: Re: [PATCH net] xen-netback: fix vif tx queue race in xenvif_rx_interrupt
Date: Wed, 08 Jan 2014 15:11:39 -0500 (EST) [thread overview]
Message-ID: <20140108.151139.4522881609697040.davem@davemloft.net> (raw)
In-Reply-To: <1389209061-29494-1-git-send-email-jieyue.majy@alibaba-inc.com>
From: Ma JieYue <majieyue@gmail.com>
Date: Thu, 9 Jan 2014 03:24:21 +0800
> - if (xenvif_rx_schedulable(vif))
> + if (netif_queue_stopped(vif->dev) && xenvif_rx_schedulable(vif))
I do not see anything which prevents a netif_stop_queue() call from happening
between these two tests in another thread of control.
This therefore looks like a bandaid and not a real fix.
next prev parent reply other threads:[~2014-01-08 20:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 19:24 [PATCH net] xen-netback: fix vif tx queue race in xenvif_rx_interrupt Ma JieYue
2014-01-08 20:11 ` David Miller [this message]
2014-01-09 9:35 ` Paul Durrant
2014-01-08 21:18 ` Zoltan Kiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140108.151139.4522881609697040.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david.vrabel@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=jieyue.majy@alibaba-inc.com \
--cc=majieyue@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=tienan.ftn@alibaba-inc.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=yingbin.wangyb@alibaba-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).