From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: "François-Xavier Le Bail" <fx.lebail@yahoo.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki Yoshifuji <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH net-next v5] IPv6: add the option to use anycast addresses as source addresses in echo reply
Date: Wed, 8 Jan 2014 09:22:54 +0100 [thread overview]
Message-ID: <20140108082254.GE9007@order.stressinduktion.org> (raw)
In-Reply-To: <1389169066.26962.YahooMailBasic@web125506.mail.ne1.yahoo.com>
On Wed, Jan 08, 2014 at 12:17:46AM -0800, François-Xavier Le Bail wrote:
> On Tue, 1/7/14, Hannes Frederic Sowa <hannes@stressinduktion.org> wrote:
>
> > On Tue, Jan 07, 2014 at 02:57:27PM +0100, Francois-Xavier Le Bail wrote:
> > > --- a/include/net/netns/ipv6.h
> > > +++ b/include/net/netns/ipv6.h
> > > @@ -73,6 +73,7 @@ struct netns_ipv6 {
> > > #endif
> > > atomic_t dev_addr_genid;
> > > atomic_t rt_genid;
> > > + int anycast_src_echo_reply;
> > > };
>
> > Sorry, I missed that on first review and you could also do that as a
> > follow-up:
>
> > Could you move anycast_src_echo_reply to netns_sysctl_ipv6?
>
> I can do that, but please explain what this change is needed.
I think it is just a matter of style so that the ipv6 knobs are kept
together.
Greetings,
Hannes
next prev parent reply other threads:[~2014-01-08 8:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 13:57 [PATCH net-next v5] IPv6: add the option to use anycast addresses as source addresses in echo reply Francois-Xavier Le Bail
2014-01-07 19:14 ` Hannes Frederic Sowa
2014-01-08 8:06 ` François-Xavier Le Bail
2014-01-07 20:51 ` Hannes Frederic Sowa
2014-01-08 8:17 ` François-Xavier Le Bail
2014-01-08 8:22 ` Hannes Frederic Sowa [this message]
2014-01-07 20:52 ` David Miller
2014-01-07 22:55 ` Bill Fink
2014-01-07 23:01 ` Hannes Frederic Sowa
2014-01-07 23:17 ` Hannes Frederic Sowa
2014-01-08 9:56 ` François-Xavier Le Bail
2014-01-07 23:33 ` David Miller
2014-01-07 23:39 ` Hannes Frederic Sowa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140108082254.GE9007@order.stressinduktion.org \
--to=hannes@stressinduktion.org \
--cc=davem@davemloft.net \
--cc=fx.lebail@yahoo.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).