From: Hariprasad S <hariprasad@chelsio.com>
To: David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <dm@chelsio.com>, <leedom@chelsio.com>,
<nirranjan@chelsio.com>, <kumaras@chelsio.com>,
<santosh@chelsio.com>
Subject: Re: [PATCH net-next 1/2] cxgb4: Fix namespace collision issue.
Date: Wed, 8 Jan 2014 16:49:24 +0530 [thread overview]
Message-ID: <20140108111923.GA15969@hariprasad-pc> (raw)
In-Reply-To: <20140107.154813.1483946457674959301.davem@davemloft.net>
On Tue, Jan 07, 2014 at 15:48:13 -0500, David Miller wrote:
> From: Hariprasad Shenai <hariprasad@chelsio.com>
> Date: Tue, 7 Jan 2014 16:58:07 +0530
>
> > Signed-off-by: Hariprasad Shenai <hariprasad@chelsio.com>
> ...
>
> > -int t4_init_tp_params(struct adapter *adap)
>
> There is no reason that an already exported function must be moved
> to solve a namespace issue.
>
> If you want to move this function for another reason, fine, but do
> it in a seperate change with a clear description of that reason in
> your commit message.
>
> I'm not applying this series.
I will drop this patch series. I will send an independent patch for FW version
check.
next prev parent reply other threads:[~2014-01-08 11:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 11:28 [PATCH net-next 0/2] namespace collision fix and update FW version check on cxgb4 Hariprasad Shenai
2014-01-07 11:28 ` [PATCH net-next 1/2] cxgb4: Fix namespace collision issue Hariprasad Shenai
2014-01-07 20:48 ` David Miller
2014-01-08 11:19 ` Hariprasad S [this message]
2014-01-07 11:28 ` [PATCH net-next 2/2] cxgb4: Changed FW check version to match FW binary version Hariprasad Shenai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140108111923.GA15969@hariprasad-pc \
--to=hariprasad@chelsio.com \
--cc=davem@davemloft.net \
--cc=dm@chelsio.com \
--cc=kumaras@chelsio.com \
--cc=leedom@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=nirranjan@chelsio.com \
--cc=santosh@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox