From: David Miller <davem@davemloft.net>
To: mark.d.rustad@intel.com
Cc: sfeldma@cumulusnetworks.com, aaron.f.brown@intel.com,
netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com
Subject: Re: [net-next 3/7] ixgbe: Use static inlines instead of macros
Date: Thu, 09 Jan 2014 14:39:23 -0500 (EST) [thread overview]
Message-ID: <20140109.143923.437905458430188006.davem@davemloft.net> (raw)
In-Reply-To: <2C8FA848-3185-43BA-BDD7-955B0C7DD835@intel.com>
From: "Rustad, Mark D" <mark.d.rustad@intel.com>
Date: Thu, 9 Jan 2014 17:34:18 +0000
> On Jan 8, 2014, at 12:47 AM, Scott Feldman <sfeldma@cumulusnetworks.com> wrote:
>
>>
>> On Jan 7, 2014, at 11:40 PM, Aaron Brown <aaron.f.brown@intel.com> wrote:
>>
>>> From: Mark Rustad <mark.d.rustad@intel.com>
>>>
>>> -#define IXGBE_WRITE_REG(a, reg, value) writel((value), ((a)->hw_addr + (reg)))
>>> +static inline void IXGBE_WRITE_REG(struct ixgbe_hw *hw, u32 reg, u32 value)
>>
>> Bummer, now you have a all-caps func name.
>
> Agreed, but this is actually a fairly common condition among drivers that used to use macros. It isn't perfect, but at least it is moving in the right direction. I'd rather leave the case change for a later patch series that does only that or has some reason to touch all of the register access sites.
>
> At least the new accessor I introduced is lower case. :-)
Please address this feedback, all caps function names are really not
appropriate.
next prev parent reply other threads:[~2014-01-09 19:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 7:40 [net-next 0/7] Intel Wired LAN Driver Updates Aaron Brown
2014-01-08 7:40 ` [net-next 1/7] ixbge: Protect ixgbe_down with __IXGBE_DOWN bit Aaron Brown
2014-01-08 7:40 ` [net-next 2/7] ixgbe: Indicate removal state explicitly Aaron Brown
2014-01-08 8:37 ` Scott Feldman
2014-01-09 17:27 ` Rustad, Mark D
2014-01-09 18:18 ` Rustad, Mark D
2014-01-09 17:29 ` Rustad, Mark D
2014-01-08 7:40 ` [net-next 3/7] ixgbe: Use static inlines instead of macros Aaron Brown
2014-01-08 8:47 ` Scott Feldman
2014-01-09 17:34 ` Rustad, Mark D
2014-01-09 19:39 ` David Miller [this message]
2014-01-09 20:14 ` Rustad, Mark D
2014-01-09 20:19 ` David Miller
2014-01-09 20:46 ` Rustad, Mark D
2014-01-09 20:59 ` David Miller
2014-01-08 7:40 ` [net-next 4/7] ixgbe: Make ethtool register test use accessors Aaron Brown
2014-01-08 7:40 ` [net-next 5/7] ixgbe: Check register reads for adapter removal Aaron Brown
2014-01-08 8:35 ` Scott Feldman
2014-01-08 7:40 ` [net-next 6/7] ixgbe: Check for adapter removal on register writes Aaron Brown
2014-01-08 7:40 ` [net-next 7/7] ixgbe: Additional adapter removal checks Aaron Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140109.143923.437905458430188006.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aaron.f.brown@intel.com \
--cc=gospo@redhat.com \
--cc=mark.d.rustad@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
--cc=sfeldma@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).