* [patch] cxgb4: silence shift wrapping static checker warning
@ 2014-01-09 5:34 Dan Carpenter
2014-01-09 5:48 ` Dimitrios Michailidis
2014-01-13 19:16 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2014-01-09 5:34 UTC (permalink / raw)
To: Dimitris Michailidis, Kumar Sanghvi; +Cc: netdev, kernel-janitors
I don't know how large "tp->vlan_shift" is but static checkers worry
about shift wrapping bugs here.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/chelsio/cxgb4/l2t.c b/drivers/net/ethernet/chelsio/cxgb4/l2t.c
index cb05be905def..81e8402a74b4 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/l2t.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/l2t.c
@@ -423,7 +423,7 @@ u64 cxgb4_select_ntuple(struct net_device *dev,
* in the Compressed Filter Tuple.
*/
if (tp->vlan_shift >= 0 && l2t->vlan != VLAN_NONE)
- ntuple |= (F_FT_VLAN_VLD | l2t->vlan) << tp->vlan_shift;
+ ntuple |= (u64)(F_FT_VLAN_VLD | l2t->vlan) << tp->vlan_shift;
if (tp->port_shift >= 0)
ntuple |= (u64)l2t->lport << tp->port_shift;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [patch] cxgb4: silence shift wrapping static checker warning
2014-01-09 5:34 [patch] cxgb4: silence shift wrapping static checker warning Dan Carpenter
@ 2014-01-09 5:48 ` Dimitrios Michailidis
2014-01-13 19:16 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Dimitrios Michailidis @ 2014-01-09 5:48 UTC (permalink / raw)
To: Dan Carpenter, Kumar A S
Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
> I don't know how large "tp->vlan_shift" is but static checkers worry
> about shift wrapping bugs here.
Indeed.
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Dimitris Michailidis <dm@chelsio.com>
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/l2t.c
> b/drivers/net/ethernet/chelsio/cxgb4/l2t.c
> index cb05be905def..81e8402a74b4 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/l2t.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/l2t.c
> @@ -423,7 +423,7 @@ u64 cxgb4_select_ntuple(struct net_device *dev,
> * in the Compressed Filter Tuple.
> */
> if (tp->vlan_shift >= 0 && l2t->vlan != VLAN_NONE)
> - ntuple |= (F_FT_VLAN_VLD | l2t->vlan) << tp->vlan_shift;
> + ntuple |= (u64)(F_FT_VLAN_VLD | l2t->vlan) << tp->vlan_shift;
>
> if (tp->port_shift >= 0)
> ntuple |= (u64)l2t->lport << tp->port_shift;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] cxgb4: silence shift wrapping static checker warning
2014-01-09 5:34 [patch] cxgb4: silence shift wrapping static checker warning Dan Carpenter
2014-01-09 5:48 ` Dimitrios Michailidis
@ 2014-01-13 19:16 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-01-13 19:16 UTC (permalink / raw)
To: dan.carpenter; +Cc: dm, kumaras, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 9 Jan 2014 08:34:00 +0300
> I don't know how large "tp->vlan_shift" is but static checkers worry
> about shift wrapping bugs here.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied to 'net'.
I don't think I'll be able to get this into 3.13, but on the off chance
Linus has to do another -rc I'll try to send it to him.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-13 19:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-09 5:34 [patch] cxgb4: silence shift wrapping static checker warning Dan Carpenter
2014-01-09 5:48 ` Dimitrios Michailidis
2014-01-13 19:16 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).