* [PATCH net-next] l2tp: make local functions static
@ 2014-01-10 6:22 Stephen Hemminger
2014-01-10 7:25 ` James Chapman
2014-01-13 20:01 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Hemminger @ 2014-01-10 6:22 UTC (permalink / raw)
To: David Miller, James Chapman; +Cc: netdev
Avoid needless export of local functions
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
net/l2tp/l2tp_core.c | 6 ++----
net/l2tp/l2tp_core.h | 2 --
2 files changed, 2 insertions(+), 6 deletions(-)
--- a/net/l2tp/l2tp_core.c 2014-01-04 13:39:54.412219520 -0800
+++ b/net/l2tp/l2tp_core.c 2014-01-04 13:42:23.577751675 -0800
@@ -176,7 +176,7 @@ l2tp_session_id_hash_2(struct l2tp_net *
* owned by userspace. A struct sock returned from this function must be
* released using l2tp_tunnel_sock_put once you're done with it.
*/
-struct sock *l2tp_tunnel_sock_lookup(struct l2tp_tunnel *tunnel)
+static struct sock *l2tp_tunnel_sock_lookup(struct l2tp_tunnel *tunnel)
{
int err = 0;
struct socket *sock = NULL;
@@ -202,10 +202,9 @@ struct sock *l2tp_tunnel_sock_lookup(str
out:
return sk;
}
-EXPORT_SYMBOL_GPL(l2tp_tunnel_sock_lookup);
/* Drop a reference to a tunnel socket obtained via. l2tp_tunnel_sock_put */
-void l2tp_tunnel_sock_put(struct sock *sk)
+static void l2tp_tunnel_sock_put(struct sock *sk)
{
struct l2tp_tunnel *tunnel = l2tp_sock_to_tunnel(sk);
if (tunnel) {
@@ -217,7 +216,6 @@ void l2tp_tunnel_sock_put(struct sock *s
}
sock_put(sk);
}
-EXPORT_SYMBOL_GPL(l2tp_tunnel_sock_put);
/* Lookup a session by id in the global session list
*/
--- a/net/l2tp/l2tp_core.h 2014-01-04 13:39:54.412219520 -0800
+++ b/net/l2tp/l2tp_core.h 2014-01-04 13:42:23.577751675 -0800
@@ -238,8 +238,6 @@ out:
return tunnel;
}
-struct sock *l2tp_tunnel_sock_lookup(struct l2tp_tunnel *tunnel);
-void l2tp_tunnel_sock_put(struct sock *sk);
struct l2tp_session *l2tp_session_find(struct net *net,
struct l2tp_tunnel *tunnel,
u32 session_id);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] l2tp: make local functions static
2014-01-10 6:22 [PATCH net-next] l2tp: make local functions static Stephen Hemminger
@ 2014-01-10 7:25 ` James Chapman
2014-01-13 20:01 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: James Chapman @ 2014-01-10 7:25 UTC (permalink / raw)
To: Stephen Hemminger, David Miller; +Cc: netdev
On 10/01/14 06:22, Stephen Hemminger wrote:
> Avoid needless export of local functions
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: James Chapman <jchapman@katalix.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] l2tp: make local functions static
2014-01-10 6:22 [PATCH net-next] l2tp: make local functions static Stephen Hemminger
2014-01-10 7:25 ` James Chapman
@ 2014-01-13 20:01 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-01-13 20:01 UTC (permalink / raw)
To: stephen; +Cc: jchapman, netdev
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Thu, 9 Jan 2014 22:22:27 -0800
> Avoid needless export of local functions
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-13 20:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-10 6:22 [PATCH net-next] l2tp: make local functions static Stephen Hemminger
2014-01-10 7:25 ` James Chapman
2014-01-13 20:01 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).