From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH net-next] net: vxlan: when lower dev unregisters remove vxlan dev as well Date: Fri, 10 Jan 2014 11:12:33 -0800 Message-ID: <20140110111233.3364ec17@nehalam.linuxnetplumber.net> References: <1389358907-19885-1-git-send-email-dborkman@redhat.com> <52D044E0.1090206@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Cong Wang , David Miller , netdev To: Daniel Borkmann Return-path: Received: from mail-pa0-f53.google.com ([209.85.220.53]:49852 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751984AbaAJTMf (ORCPT ); Fri, 10 Jan 2014 14:12:35 -0500 Received: by mail-pa0-f53.google.com with SMTP id hz1so5144325pad.12 for ; Fri, 10 Jan 2014 11:12:35 -0800 (PST) In-Reply-To: <52D044E0.1090206@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 10 Jan 2014 20:07:12 +0100 Daniel Borkmann wrote: > >> + BUG_ON(!rtnl_is_locked()); > > > > > > This is not necessary at all, it is known that netdev notication > > holds rtnl lock. > > We're not in fast-path, and if someone would call that function outside > of the notifier chain, it might be good to check if the lock was taken, > but if there's a strong opinion to not have that, I'll just remove it First, the standard way to do this is ASSERT_RTNL() Second, it is unnecessary. The function is local, only called through notifier and notifiers always have RTNL held.