From: David Miller <davem@davemloft.net>
To: hayeswang@realtek.com
Cc: oliver@neukum.org, netdev@vger.kernel.org, nic_swsd@realtek.com,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH net-next 3/3] r8152: add supporting the vendor mode only
Date: Mon, 13 Jan 2014 11:19:36 -0800 (PST) [thread overview]
Message-ID: <20140113.111936.1286616042680494607.davem@davemloft.net> (raw)
In-Reply-To: <1389250232-8663-4-git-send-email-hayeswang@realtek.com>
From: Hayes Wang <hayeswang@realtek.com>
Date: Thu, 9 Jan 2014 14:50:32 +0800
> Remove the limitation that the ecm and r8152 drivers couldn't coexist.
> Besides, add the feature to support the vendor mode only. This let
> someone who doesn't want to use ecm driver easy to use the vendor
> driver without creating the udev rule.
>
> Signed-off-by: Hayes Wang <hayeswang@realtek.com>
This is a very bad precedence and I do not want drivers to start doing
things like this.
I think it would be wiser to use the existing facilities which exist
to control this situation, and yes udev is one of them.
I'm sorry, I'm not applying this series as long as it has this patch
in it.
next prev parent reply other threads:[~2014-01-13 19:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 6:50 [PATCH net-next 0/3] r8152: behavior modification Hayes Wang
2014-01-09 6:50 ` [PATCH net-next 1/3] r8152: change the descriptor Hayes Wang
2014-01-09 6:50 ` [PATCH net-next 2/3] r8152: fix the warnings and a error from checkpatch.pl Hayes Wang
2014-01-09 6:50 ` [PATCH net-next 3/3] r8152: add supporting the vendor mode only Hayes Wang
2014-01-13 19:19 ` David Miller [this message]
2014-01-15 2:42 ` [PATCH net-next v2 0/3] r8152: remove limitation Hayes Wang
2014-01-15 2:42 ` [PATCH net-next v2 1/3] r8152: change the descriptor Hayes Wang
2014-01-15 2:42 ` [PATCH net-next v2 2/3] r8152: fix the warnings and a error from checkpatch.pl Hayes Wang
[not found] ` <1389753736-2218-1-git-send-email-hayeswang-Rasf1IRRPZFBDgjK7y7TUQ@public.gmane.org>
2014-01-15 2:42 ` [PATCH net-next v2 3/3] r8152: ecm and vendor modes coexist Hayes Wang
2014-01-15 2:49 ` [PATCH net-next v2 0/3] r8152: remove limitation David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140113.111936.1286616042680494607.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).