From: David Miller <davem@davemloft.net>
To: stephen@networkplumber.org
Cc: ariele@broadcom.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] bnx2x: namespace and dead code cleanups
Date: Mon, 13 Jan 2014 12:00:55 -0800 (PST) [thread overview]
Message-ID: <20140113.120055.7725617708311037.davem@davemloft.net> (raw)
In-Reply-To: <20140109222011.59eb4ff1@nehalam.linuxnetplumber.net>
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Thu, 9 Jan 2014 22:20:11 -0800
> Fix a bunch of whole lot of namespace issues with the Broadcom bnx2x driver
> found by running 'make namespacecheck'
>
> * global variables must be prefixed with bnx2x_
> naming a variable int_mode, or num_queue is invitation to disaster
>
> * make local functions static
>
> * move some inline's used in one file out of header
> (this driver has a bad case of inline-itis)
>
> * remove resulting dead code fallout
> bnx2x_pfc_statistic,
> bnx2x_emac_get_pfc_stat
> bnx2x_init_vlan_mac_obj,
> Looks like vlan mac support in this driver was a botch from day one
> either never worked, or not implemented or missing support functions
>
> Compile tested only.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Applied.
prev parent reply other threads:[~2014-01-13 20:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 6:20 [PATCH net-next] bnx2x: namespace and dead code cleanups Stephen Hemminger
2014-01-13 20:00 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140113.120055.7725617708311037.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ariele@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox