From: David Miller <davem@davemloft.net>
To: roy.qing.li@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2] ipv6: move IPV6_TCLASS_SHIFT into ipv6.h
Date: Mon, 13 Jan 2014 21:25:40 -0800 (PST) [thread overview]
Message-ID: <20140113.212540.653813046935024687.davem@davemloft.net> (raw)
In-Reply-To: <1389348199-5855-1-git-send-email-roy.qing.li@gmail.com>
From: roy.qing.li@gmail.com
Date: Fri, 10 Jan 2014 18:03:18 +0800
> @@ -150,6 +150,8 @@ static int fib6_rule_match(struct fib_rule *rule, struct flowi *fl, int flags)
> {
> struct fib6_rule *r = (struct fib6_rule *) rule;
> struct flowi6 *fl6 = &fl->u.ip6;
> + u8 tclass = ntohl(fl6->flowlabel & IPV6_TCLASS_MASK) >>
> + IPV6_TCLASS_SHIFT;
As others have mentioned, please make a helper inline function or
macro for this calculation. It happens in two places.
Thanks.
prev parent reply other threads:[~2014-01-14 5:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 10:03 [PATCH net-next v2] ipv6: move IPV6_TCLASS_SHIFT into ipv6.h roy.qing.li
2014-01-10 18:33 ` Cong Wang
2014-01-14 5:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140113.212540.653813046935024687.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=roy.qing.li@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox