From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] sh_eth: fix garbled TX error message Date: Mon, 13 Jan 2014 23:29:35 -0800 (PST) Message-ID: <20140113.232935.776174177146650322.davem@davemloft.net> References: <201401110241.49471.sergei.shtylyov@cogentembedded.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-sh@vger.kernel.org To: sergei.shtylyov@cogentembedded.com Return-path: In-Reply-To: <201401110241.49471.sergei.shtylyov@cogentembedded.com> Sender: linux-sh-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Sergei Shtylyov Date: Sat, 11 Jan 2014 02:41:49 +0300 > sh_eth_error() in case of a TX error tries to print a message using 2 dev_err() > calls with the first string not finished by '\n', so that the resulting message > would inevitably come out garbled, with something like "3net eth0: " inserted > in the middle. Avoid that by merging 2 calls into one. > > While at it, insert an empty line after the nearby declaration. > > Signed-off-by: Sergei Shtylyov Applied, thanks. I don't think this is really -stable material, sorry.