From: David Miller <davem@davemloft.net>
To: xiyou.wangcong@gmail.com
Cc: netdev@vger.kernel.org, jhs@mojatatu.com
Subject: Re: [Patch net-next] net_sched: act: remove headers in include/net/tc_act/
Date: Tue, 14 Jan 2014 18:12:13 -0800 (PST) [thread overview]
Message-ID: <20140114.181213.695613248997119103.davem@davemloft.net> (raw)
In-Reply-To: <1389747699-32508-1-git-send-email-xiyou.wangcong@gmail.com>
From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Tue, 14 Jan 2014 17:01:39 -0800
> These headers are not necessary because those definitions in them
> are action specific and are not shared for others. Just move them
> into the C files.
>
> Cc: Jamal Hadi Salim <jhs@mojatatu.com>
> Cc: David S. Miller <davem@davemloft.net>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Like Eric, I think this is a dubious change.
There is nothing wrong with using these headers to define the
core data structures used by each of these actions modules.
I'm not applying this, sorry.
next prev parent reply other threads:[~2014-01-15 2:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 1:01 [Patch net-next] net_sched: act: remove headers in include/net/tc_act/ Cong Wang
2014-01-15 1:11 ` Eric Dumazet
2014-01-15 1:17 ` Cong Wang
2014-01-15 2:12 ` David Miller [this message]
2014-01-15 18:57 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140114.181213.695613248997119103.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox