[PATCH RESEND net-next v2 0/3] bonding: fix primary problem for bonding

[PATCH RESEND net-next v2 0/3] bonding: fix primary problem for bonding

[Ding Tianhong]

If the slave's name changed, and the bond params primary is exist,
the bond should deal with the situation in two ways:

1) If the slave was the primary slave yet, clean the primary slave
   and reselect active slave.
2) If the slave's new name is as same as bond primary, set the slave
   as primary slave and reselect active slave.

If the new primary is not matching any slave in the bond, the bond should
record it to params, clean the primary slave and select a new active slave.

Update bonding.txt for primary description.

Ding Tianhong (3):
  bonding: update the primary slave when changing slave's name
  bonding: clean the primary slave if there is no slave matching new
    primary
  bonding: update bonding.txt for primary description.

 Documentation/networking/bonding.txt |  3 ++-
 drivers/net/bonding/bond_main.c      | 24 ++++++++++++++++++++++--
 drivers/net/bonding/bond_options.c   |  6 ++++++
 3 files changed, 30 insertions(+), 3 deletions(-)

-- 
1.8.0

Re: [PATCH RESEND net-next v2 0/3] bonding: fix primary problem for bonding

[Veaceslav Falico]

On Tue, Jan 14, 2014 at 05:08:18PM +0800, Ding Tianhong wrote:
>If the slave's name changed, and the bond params primary is exist,
>the bond should deal with the situation in two ways:
>
>1) If the slave was the primary slave yet, clean the primary slave
>   and reselect active slave.
>2) If the slave's new name is as same as bond primary, set the slave
>   as primary slave and reselect active slave.
>
>If the new primary is not matching any slave in the bond, the bond should
>record it to params, clean the primary slave and select a new active slave.
>
>Update bonding.txt for primary description.

You didn't even take into accoung my previous messages.

Nacked-by: Veaceslav Falico <vfalico@redhat.com>

>
>Ding Tianhong (3):
>  bonding: update the primary slave when changing slave's name
>  bonding: clean the primary slave if there is no slave matching new
>    primary
>  bonding: update bonding.txt for primary description.
>
> Documentation/networking/bonding.txt |  3 ++-
> drivers/net/bonding/bond_main.c      | 24 ++++++++++++++++++++++--
> drivers/net/bonding/bond_options.c   |  6 ++++++
> 3 files changed, 30 insertions(+), 3 deletions(-)
>
>-- 
>1.8.0
>
>
>

Re: [PATCH RESEND net-next v2 0/3] bonding: fix primary problem for bonding

[Ding Tianhong]

On 2014/1/14 17:37, Veaceslav Falico wrote:
> On Tue, Jan 14, 2014 at 05:08:18PM +0800, Ding Tianhong wrote:
>> If the slave's name changed, and the bond params primary is exist,
>> the bond should deal with the situation in two ways:
>>
>> 1) If the slave was the primary slave yet, clean the primary slave
>>   and reselect active slave.
>> 2) If the slave's new name is as same as bond primary, set the slave
>>   as primary slave and reselect active slave.
>>
>> If the new primary is not matching any slave in the bond, the bond should
>> record it to params, clean the primary slave and select a new active slave.
>>
>> Update bonding.txt for primary description.
> 
> You didn't even take into accoung my previous messages.
> 
> Nacked-by: Veaceslav Falico <vfalico@redhat.com>
> 

Yes, miss it, sorry about that, add and resend later.



>>
>> Ding Tianhong (3):
>>  bonding: update the primary slave when changing slave's name
>>  bonding: clean the primary slave if there is no slave matching new
>>    primary
>>  bonding: update bonding.txt for primary description.
>>
>> Documentation/networking/bonding.txt |  3 ++-
>> drivers/net/bonding/bond_main.c      | 24 ++++++++++++++++++++++--
>> drivers/net/bonding/bond_options.c   |  6 ++++++
>> 3 files changed, 30 insertions(+), 3 deletions(-)
>>
>> -- 
>> 1.8.0
>>
>>
>>
> 
>