From mboxrd@z Thu Jan 1 00:00:00 1970 From: Veaceslav Falico Subject: Re: [PATCH net-next v2.1 0/3] bonding: fix primary problem for bonding Date: Tue, 14 Jan 2014 11:55:37 +0100 Message-ID: <20140114105537.GD20066@redhat.com> References: <52D5174D.4070807@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Cc: Jay Vosburgh , Netdev , "David S. Miller" To: Ding Tianhong Return-path: Received: from mx1.redhat.com ([209.132.183.28]:48259 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751825AbaANK6l (ORCPT ); Tue, 14 Jan 2014 05:58:41 -0500 Content-Disposition: inline In-Reply-To: <52D5174D.4070807@huawei.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Jan 14, 2014 at 06:54:05PM +0800, Ding Tianhong wrote: >If the slave's name changed, and the bond params primary is exist, >the bond should deal with the situation in two ways: > >1) If the slave was the primary slave yet, clean the primary slave > and reselect active slave. >2) If the slave's new name is as same as bond primary, set the slave > as primary slave and reselect active slave. > >If the new primary is not matching any slave in the bond, the bond should >record it to params, clean the primary slave and select a new active slave. > >Update bonding.txt for primary description. > >v2.1 Because there are too many indentions and useless verification, so rewrite > the logic for updating the primary slave. > Modify some comments for to clean the typos. LOL. That's exactly what I was talking about in my previous email. A quick fix that doesn't even address the issues. Nacked-by: Veaceslav Falico > >Ding Tianhong (3): > bonding: update the primary slave when changing slave's name > bonding: clean the primary slave if there is no slave matching new > primary > bonding: update bonding.txt for primary description. > > Documentation/networking/bonding.txt | 3 ++- > drivers/net/bonding/bond_main.c | 24 ++++++++++++++++++++++-- > drivers/net/bonding/bond_options.c | 6 ++++++ > 3 files changed, 30 insertions(+), 3 deletions(-) > >-- >1.8.0 > > >