From: David Miller <davem@davemloft.net>
To: vbridgers2013@gmail.com
Cc: bhutchings@solarflare.com, devicetree@vger.kernel.org,
netdev@vger.kernel.org, peppe.cavallaro@st.com,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
dinguyen@altera.com, rayagond@vayavyalabs.com
Subject: Re: [PATCH net-next v3 2/2] stmmac: Fix kernel crashes for jumbo frames
Date: Wed, 15 Jan 2014 14:57:25 -0800 (PST) [thread overview]
Message-ID: <20140115.145725.801343084524328515.davem@davemloft.net> (raw)
In-Reply-To: <CAOwfj2Ne1oRU1z6BaH4g2_EJJFtJOWbgs2oMzSq5nNpz9G6LsA@mail.gmail.com>
From: Vince Bridgers <vbridgers2013@gmail.com>
Date: Tue, 14 Jan 2014 14:44:35 -0600
> On Tue, Jan 14, 2014 at 1:53 PM, Ben Hutchings
> <bhutchings@solarflare.com> wrote:
>> On Tue, 2014-01-14 at 11:17 -0600, Vince Bridgers wrote:
>>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>>> @@ -51,6 +51,10 @@ static int stmmac_probe_config_dt(struct platform_device *pdev,
>>> plat->mdio_bus_data = devm_kzalloc(&pdev->dev,
>>> sizeof(struct stmmac_mdio_bus_data),
>>> GFP_KERNEL);
>>> + /* Set the maxmtu to a default of 1500 in case the
>>> + * parameter is not present in the device tree
>>> + */
>>> + plat->maxmtu = JUMBO_LEN;
>>
>> The comment disagrees with the definition of JUMBO_LEN.
>
> ok, I'll address the comment inconsistency.
Therefore I'm expecting to see a v4 of this series at some point,
thanks.
prev parent reply other threads:[~2014-01-15 22:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 17:17 [PATCH net-next v3 0/2] stmmac: fix kernel crashes for jumbo frames Vince Bridgers
2014-01-14 17:17 ` [PATCH net-next v3 1/2] dts: Add a binding for Synopsys emac max-frame-size Vince Bridgers
2014-01-14 17:17 ` [PATCH net-next v3 2/2] stmmac: Fix kernel crashes for jumbo frames Vince Bridgers
2014-01-14 19:53 ` Ben Hutchings
2014-01-14 20:44 ` Vince Bridgers
2014-01-14 23:20 ` Ben Hutchings
2014-01-15 22:57 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140115.145725.801343084524328515.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@altera.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=peppe.cavallaro@st.com \
--cc=rayagond@vayavyalabs.com \
--cc=robh+dt@kernel.org \
--cc=vbridgers2013@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).