* [PATCH net-next] bnad: code cleanup
@ 2014-01-15 16:24 Stephen Hemminger
2014-01-17 0:23 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2014-01-15 16:24 UTC (permalink / raw)
To: Rasesh Mody, David Miller; +Cc: netdev
Use 'make namespacecheck' to code that could be declared static.
After that remove code that is not being used.
Compile tested only.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/ethernet/brocade/bna/bfa_ioc.c | 27 +--------------------------
drivers/net/ethernet/brocade/bna/bnad.c | 2 +-
2 files changed, 2 insertions(+), 27 deletions(-)
--- a/drivers/net/ethernet/brocade/bna/bnad.c 2014-01-14 09:46:15.261710097 -0800
+++ b/drivers/net/ethernet/brocade/bna/bnad.c 2014-01-14 09:47:43.800754593 -0800
@@ -2108,7 +2108,7 @@ bnad_rx_ctrl_init(struct bnad *bnad, u32
}
/* Called with mutex_lock(&bnad->conf_mutex) held */
-u32
+static u32
bnad_reinit_rx(struct bnad *bnad)
{
struct net_device *netdev = bnad->netdev;
--- a/drivers/net/ethernet/brocade/bna/bfa_ioc.c 2014-01-14 09:46:15.261710097 -0800
+++ b/drivers/net/ethernet/brocade/bna/bfa_ioc.c 2014-01-14 09:47:43.800754593 -0800
@@ -1147,25 +1147,6 @@ bfa_nw_ioc_sem_release(void __iomem *sem
writel(1, sem_reg);
}
-/* Invalidate fwver signature */
-enum bfa_status
-bfa_nw_ioc_fwsig_invalidate(struct bfa_ioc *ioc)
-{
- u32 pgnum, pgoff;
- u32 loff = 0;
- enum bfi_ioc_state ioc_fwstate;
-
- ioc_fwstate = bfa_ioc_get_cur_ioc_fwstate(ioc);
- if (!bfa_ioc_state_disabled(ioc_fwstate))
- return BFA_STATUS_ADAPTER_ENABLED;
-
- pgnum = bfa_ioc_smem_pgnum(ioc, loff);
- pgoff = PSS_SMEM_PGOFF(loff);
- writel(pgnum, ioc->ioc_regs.host_page_num_fn);
- writel(BFI_IOC_FW_INV_SIGN, ioc->ioc_regs.smem_page_start + loff);
- return BFA_STATUS_OK;
-}
-
/* Clear fwver hdr */
static void
bfa_ioc_fwver_clear(struct bfa_ioc *ioc)
@@ -1780,15 +1761,9 @@ bfa_flash_raw_read(void __iomem *pci_bar
return BFA_STATUS_OK;
}
-u32
-bfa_nw_ioc_flash_img_get_size(struct bfa_ioc *ioc)
-{
- return BFI_FLASH_IMAGE_SZ/sizeof(u32);
-}
-
#define BFA_FLASH_PART_FWIMG_ADDR 0x100000 /* fw image address */
-enum bfa_status
+static enum bfa_status
bfa_nw_ioc_flash_img_get_chnk(struct bfa_ioc *ioc, u32 off,
u32 *fwimg)
{
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] bnad: code cleanup
2014-01-15 16:24 [PATCH net-next] bnad: code cleanup Stephen Hemminger
@ 2014-01-17 0:23 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-01-17 0:23 UTC (permalink / raw)
To: stephen; +Cc: rmody, netdev
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Wed, 15 Jan 2014 08:24:21 -0800
> Use 'make namespacecheck' to code that could be declared static.
> After that remove code that is not being used.
>
> Compile tested only.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-17 0:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-15 16:24 [PATCH net-next] bnad: code cleanup Stephen Hemminger
2014-01-17 0:23 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).