Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: bhutchings@solarflare.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: eth_type_trans() should use skb_header_pointer()
Date: Thu, 16 Jan 2014 15:30:44 -0800 (PST)	[thread overview]
Message-ID: <20140116.153044.1318855011954380596.davem@davemloft.net> (raw)
In-Reply-To: <1389913411.31367.430.camel@edumazet-glaptop2.roam.corp.google.com>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 16 Jan 2014 15:03:31 -0800

> From: Eric Dumazet <edumazet@google.com>
> 
> eth_type_trans() can read uninitialized memory as drivers
> do not necessarily pull more than 14 bytes in skb->head before
> calling it.
> 
> As David suggested, we can use skb_header_pointer() to
> fix this without breaking some drivers that might not expect
> eth_type_trans() pulling 2 additional bytes.
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Ben Hutchings <bhutchings@solarflare.com>
> ---
> Since this bug is very old, I cooked the patch on net-next

Applied, thanks a lot Eric.

  reply	other threads:[~2014-01-16 23:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-14 23:52 [BUG] eth_type_trans() can access stale data Eric Dumazet
2014-01-15  0:21 ` Ben Hutchings
2014-01-16 23:03   ` [PATCH net-next] net: eth_type_trans() should use skb_header_pointer() Eric Dumazet
2014-01-16 23:30     ` David Miller [this message]
2014-01-15 23:48 ` [BUG] eth_type_trans() can access stale data David Miller
2014-01-16 20:15   ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140116.153044.1318855011954380596.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bhutchings@solarflare.com \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox